From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [patch] make electric-pair-mode smarter/more useful Date: Sat, 14 Dec 2013 18:56:06 +0200 Message-ID: <52AC8DA6.5070403@yandex.ru> References: <87haalh806.fsf@gmail.com> <87d2l9wfne.fsf@yandex.ru> <87fvq49xzp.fsf@gmail.com> <87vbyuwyyc.fsf@gmail.com> <52A93B99.8040308@yandex.ru> <87r49if185.fsf@gmail.com> <52AA772D.7050503@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1387040191 27071 80.91.229.3 (14 Dec 2013 16:56:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Dec 2013 16:56:31 +0000 (UTC) Cc: =?ISO-8859-1?Q?Jo=E3o_T=E1vora?= , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 14 17:56:38 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VrsW3-0006gb-Hy for ged-emacs-devel@m.gmane.org; Sat, 14 Dec 2013 17:56:35 +0100 Original-Received: from localhost ([::1]:47857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrsW3-0000kf-9C for ged-emacs-devel@m.gmane.org; Sat, 14 Dec 2013 11:56:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrsVt-0000kT-Ao for emacs-devel@gnu.org; Sat, 14 Dec 2013 11:56:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrsVg-0002v9-89 for emacs-devel@gnu.org; Sat, 14 Dec 2013 11:56:25 -0500 Original-Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:49614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrsVg-0002v5-1H for emacs-devel@gnu.org; Sat, 14 Dec 2013 11:56:12 -0500 Original-Received: by mail-ea0-f176.google.com with SMTP id h14so1401124eaj.21 for ; Sat, 14 Dec 2013 08:56:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=MIuOxHnHMdDU0DeTw9Fk4lH1aYYqKpdG98MK4T9AAQo=; b=qb7naxyg2AWLZZ1FGQXbqIabae3QzxR3QcLflvTnGxev9fXXAcmgLIc4A0SB5+GxHc BfZPj2yU7cqxhoMKsqId5fk3wF0UcKUZ0UhN0fmEc8/fSSldPAu8b1hcXjw2+1peo6xY fdZToqzA3cWvzzKpyoyGJ2zGsOt59l1XGCctkVS4DnMqjOQjW6xFPL/9Xufjq2g3/e0r rv43R1TbHdPMLVeVTuYDwlOQlxXZWGJJdbxw7wDxc1ag3wQDkZzLE0Jg9Mz/tbw6PCkE vaQTR1uWXDCXAJyrt02yd7n28DqA8pRlsb8iI9Hpb1vGIR28V8w4Pa1GMpLOEzerObzD Ze+A== X-Received: by 10.14.6.5 with SMTP id 5mr8334167eem.51.1387040170716; Sat, 14 Dec 2013 08:56:10 -0800 (PST) Original-Received: from [192.168.10.2] ([83.168.26.131]) by mx.google.com with ESMTPSA id o1sm20397282eea.10.2013.12.14.08.56.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Dec 2013 08:56:09 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166393 Archived-At: On 14.12.2013 17:18, Stefan Monnier wrote: > I'm not completely sure I understand our question w.r.t the code you > quoted: the code you quoted adds the behavior globally, so it obviously > wouldn't be set on a per-mode basis. Yes, but if it's set via electric-layout-rules, to what value will this variable be set in e.g. js-mode? If it'll include what's there currently, '((?\; . after) (?\{ . after) (?\} . before)), then to get the desired behavior I described previously (NOT to insert a newline after I just typed `{', or any other character), I'd have to modify it again in js-mode-hook. IOW, turning on electric-layout-mode would turn on all electric-layout-related behaviors defined for a given major mode. Are we willing to remove electric newlines after `;', `{' and `}', by default, from any major mode where one of those might conceivably be followed by some character other than newline? Speaking of cc-mode, I don't really program in C (though I'd like to continue learning it at some point), but if I did, I'm not sure I'd want the electric-layout-mode behavior there, but electric-pair-newline-between-pairs-rule would be useful. >> For example, like described previously, if I want js-mode to only insert >> electric newlines when I press return, will I have to modify >> electric-layout-rules in js-mode-hook, and do so for any other mode I use >> that sets this variable? > > I think setting it on a per-mode basis would be OK, but it wouldn't be > set by the user but instead by the major mode, based on the usual coding > style used for that mode. E.g. we wouldn't set it in Lisp, but we'd set > it in js-mode. Yes. And similarly, if we have a separate minor mode, it will be disabled (maybe via some -inhibit variable) by some major modes.