all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 16116@debbugs.gnu.org
Subject: bug#16116: 24.3.50; smie-indent-close aligns inner closing paren with the outer opening paren
Date: Thu, 12 Dec 2013 18:30:39 +0200	[thread overview]
Message-ID: <52A9E4AF.40006@yandex.ru> (raw)
In-Reply-To: <jwvmwk68c17.fsf-monnier+emacsbugs@gnu.org>

On 12.12.2013 14:55, Stefan Monnier wrote:
> Well, it does look right to me, because that line closes the whole construct.

Here are some arguments on why it's wrong:

- It deforms the last array literal and breaks the symmetry with the 
previous one.

- If it emphasizes the fact that the construct is closed, why doesn't it 
align the opening and closing round parens, and aligns delimiters from 
different sexps instead?

- What about the following example? The last line likewise closes the 
whole construct, but we don't indent it to the 0th column, right?

foo(
   a,
   b,
   c)

- Likewise, this example:

foo([a,
      b])

- Indentation functions usually don't care about tokens that go after 
the first one after indentation. I'm used to that. For example, take 
js-mode. It handles the initial example differently, but compare this 
one under both modes:

foo([a,
      b
     ])

js-mode indents it as I would expect.

- If I want to emphasize the closing of the whole construct, I can put 
the closing paren on a separate line.





  reply	other threads:[~2013-12-12 16:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  1:57 bug#16116: 24.3.50; smie-indent-close aligns inner closing paren with the outer opening paren Dmitry Gutov
2013-12-12 12:55 ` Stefan Monnier
2013-12-12 16:30   ` Dmitry Gutov [this message]
2013-12-14  8:23 ` Steve Purcell
2013-12-14 14:13   ` Stefan Monnier
2013-12-14 15:04     ` Dmitry Gutov
2013-12-14 15:32       ` Stefan Monnier
2013-12-14 18:25         ` Dmitry Gutov
2013-12-15  1:50           ` Stefan Monnier
2013-12-15  2:44             ` Dmitry Gutov
2013-12-15 13:00               ` Stefan Monnier
2013-12-15 23:22                 ` Dmitry Gutov
2013-12-16 14:23                   ` Stefan Monnier
2013-12-17  3:03                     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A9E4AF.40006@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=16116@debbugs.gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.