all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 15874@debbugs.gnu.org, Bozhidar Batsov <bozhidar@batsov.com>
Subject: bug#15874: 24.3.50; exit! not properly font-locked in ruby-mode
Date: Thu, 05 Dec 2013 00:33:06 +0200	[thread overview]
Message-ID: <529FADA2.8020106@yandex.ru> (raw)
In-Reply-To: <jwv7gbkqva9.fsf-monnier+emacsbugs@gnu.org>

On 04.12.2013 21:20, Stefan Monnier wrote:
>> I'm not sure we want to move `!' to the symbol syntax class.
>
> How is the Ruby lexing done w.r.t identifiers and ! (and ?) ?

There's no special handling: ? is considered a part of whatever token 
it's adjacent to (even when the token follows it, ex. "?wut"), and ! is 
considered a separate token.

The former is usually harmless, as far as indentation and syntax 
highlighting are concerned (*), but not considering ! a part of 
preceding token makes us mishandle the (rare, to be sure) method names 
like "else!" and "end!".

(*) Counterexample:

irb(main):013:0> def foo?
irb(main):014:1> 42
irb(main):015:1> end
=> nil
irb(main):016:0> begin; foo?end
=> 42

We don't treat "end" in "begin; foo?end" as a keyword, but ideally, we 
should.





  reply	other threads:[~2013-12-04 22:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 12:38 bug#15874: 24.3.50; exit! not properly font-locked in ruby-mode Bozhidar Batsov
2013-12-04 18:31 ` Dmitry Gutov
2013-12-04 19:20   ` Stefan Monnier
2013-12-04 22:33     ` Dmitry Gutov [this message]
2013-12-04 23:15     ` Dmitry Gutov
2013-12-05  2:50       ` Stefan Monnier
2013-12-05  3:42         ` Dmitry Gutov
2013-12-05 19:02           ` Stefan Monnier
2013-12-06  2:44             ` Dmitry Gutov
2013-12-06  4:57               ` Stefan Monnier
2013-12-06  4:23             ` Dmitry Gutov
2013-12-05  6:34   ` Kevin Rodgers
2013-12-05 10:58     ` Dmitry Gutov
2013-12-05 14:50       ` Kevin Rodgers
2013-12-05 17:25         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529FADA2.8020106@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=15874@debbugs.gnu.org \
    --cc=bozhidar@batsov.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.