From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers.
Date: Mon, 02 Dec 2013 04:40:09 +0200 [thread overview]
Message-ID: <529BF309.4010109@yandex.ru> (raw)
In-Reply-To: <jwvzjok477k.fsf-monnier+emacs@gnu.org>
On 01.12.2013 23:10, Stefan Monnier wrote:
> In the case of *VC-Log* we could have a kill-buffer-hook which prompts
> the user and aborts the kill if the user says he doesn't want to throw
> away his incomplete comment. But as you point out below, we could also
> instead have a kill-buffer-hook which saves the incomplete comment to
> log-edit-comment-ring so the buffer can be deleted without losing
> valuable info and hence without prompting.
kill-buffer-hook runs when the user already chose to kill the current
buffer (i.e. called kill-buffer and picked the current one), so that
looks wasteful, unless the prompt is triggered by a new command that
doesn't otherwise ask for any user input.
> As long as the data is stored in log-edit-comment-ring I think it's OK
> to kill without prompting.
Ok, so I went ahead and installed some changes in 115345 that hopefully
aren't too far from what you imagined.
`log-edit-kill-buffer' does a bunch of different stuff, so I feel its
presence as a separate command is justified.
I've also tried to put `log-edit-hide-buf' in kill-buffer-hook instead,
but this way, opening log-edit buffer and then closing it via
`log-edit-kill-buffer' made adjacent vertical splits (when present) jump
too far, AFAICT because then `quit-windows-on' is called on the log-edit
buffer before the log-edit-files window is deleted.
Also see the FIXME in log-edit-hide-buf.
next prev parent reply other threads:[~2013-12-02 2:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VlqjS-0006O3-Fn@vcs.savannah.gnu.org>
2013-11-29 4:39 ` trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers Dmitry Gutov
2013-11-29 13:33 ` Stefan Monnier
2013-11-29 14:53 ` Dmitry Gutov
2013-11-29 17:04 ` Stefan Monnier
2013-11-29 22:37 ` Dmitry Gutov
2013-11-30 2:29 ` Stefan Monnier
2013-11-30 16:02 ` Dmitry Gutov
2013-12-01 21:10 ` Stefan Monnier
2013-12-02 2:40 ` Dmitry Gutov [this message]
2013-12-02 13:53 ` Stefan Monnier
2013-12-02 23:02 ` Dmitry Gutov
2013-12-03 0:56 ` Leo Liu
2013-12-03 3:06 ` Stefan Monnier
2013-12-04 0:38 ` Dmitry Gutov
2013-12-03 2:17 ` Dmitry Gutov
2013-12-03 3:09 ` Stefan Monnier
2013-12-04 0:43 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529BF309.4010109@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.