From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers. Date: Sat, 30 Nov 2013 18:02:16 +0200 Message-ID: <529A0C08.8010809@yandex.ru> References: <871u1zes89.fsf@yandex.ru> <5298AA77.4060009@yandex.ru> <52991737.9000904@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1385827362 1549 80.91.229.3 (30 Nov 2013 16:02:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Nov 2013 16:02:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 30 17:02:47 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vmn0E-0008MB-JP for ged-emacs-devel@m.gmane.org; Sat, 30 Nov 2013 17:02:42 +0100 Original-Received: from localhost ([::1]:52424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmn0E-0006it-0i for ged-emacs-devel@m.gmane.org; Sat, 30 Nov 2013 11:02:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmn02-0006ic-Mh for emacs-devel@gnu.org; Sat, 30 Nov 2013 11:02:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vmmzt-0004fh-JD for emacs-devel@gnu.org; Sat, 30 Nov 2013 11:02:30 -0500 Original-Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:47848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmmzt-0004fd-Cf for emacs-devel@gnu.org; Sat, 30 Nov 2013 11:02:21 -0500 Original-Received: by mail-we0-f172.google.com with SMTP id w62so4731395wes.3 for ; Sat, 30 Nov 2013 08:02:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=bbj9JPOMW1aBKIMf413cmPkNfmF6kcYpC045P1j2vLg=; b=F0swpD4mfBoX0+29QqxCNRCxqHC+UAL3DzaawCB9fJBALDysUS1Ov8lHfCM8vF23ty j9LG3BiKxxSGhpaG43wZqf57X2+qB5CPJQodfPKlf2vpA25bKYsTlW4zMlfMWsFtn6zO iaKYZkMSoVq2BhMRcallZdpgzw5MiVR2B67REYVUN/Wi734Xoo5MmyNWdiP5pekzIRr+ 2nrmx7RZT5Qlf0u+H4Z8bG9I2QV9XMoSaMT+T/60Bjwj/MpmwNc+8JJpHwmqrKBw2YhC BJILt6wAtPum6JG0VYw+wZY7q5vrRyPShrocQBmch8ao+nSfUtHYIAYIfyK/cQVD27Rd 4tQA== X-Received: by 10.180.108.42 with SMTP id hh10mr11202321wib.15.1385827340232; Sat, 30 Nov 2013 08:02:20 -0800 (PST) Original-Received: from [192.168.10.2] (83-43-131.netrun.cytanet.com.cy. [83.168.43.131]) by mx.google.com with ESMTPSA id s20sm103414901wib.1.2013.11.30.08.02.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 30 Nov 2013 08:02:19 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165939 Archived-At: On 30.11.2013 04:29, Stefan Monnier wrote: > Note that a solution that applies only to ChangeLog wouldn't help for > the `elpa' branch. And hopefully at some point it won't help for > `emacs' either because we'll have finally rid ourselves of the > ChangeLog files. Ok, good point. If other contributors have no new suggestions, I'll be content with a user option. > We could easily highlight Summary specially after the Nth character. > [ Not sure why it should be 50, and that number might need to > depend on the backend, but other than that, I don't see > any particular difficulty. ] 50 is just a convention, so it shouldn't be inherently different for any other backend. And a safe-local user option will allow users to set it per project. >> Actually, now that I've checked, `C-c C-k' in both `message-mode' and >> git-commit-mode' that Magit uses kill the buffer after doing some cleanup, >> not bury it. Would you be fine with that? > > Seems a bit pointless since C-x k (and kill-this-buffer) works as well > for *VC-Log*, AFAIK. Why do we have `message-kill-buffer', `rcirc-multiline-minor-cancel' and `org-kill-note-or-show-branches'? As I see it, they mean "abort the current action, clean up its data, restore the previous window configuration". Having a similar command with the same binding in log-edit would be natural. Among other things, it would delete the *log-edit-files* window and quit-window on the current buffer (maybe deleting the window as a result). We can go against the similar commands and refrain from killing the buffer, but why keep it? We can also save the aborted commit message to log-edit-comment-ring. >> I think it can look better than using a separate window. But then again, >> it's how other editors do it, so it might just be more familiar. > > I used a separate window because it seemed easier, avoiding the usual > problems with display-only-text or with text-that-will-disappear, which > both can lead to surprising behaviors for the unsuspecting user. Ok, I can work with either approach.