From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: C-g while exiting the minibuffer
Date: Sat, 30 Nov 2013 13:16:47 +0100 [thread overview]
Message-ID: <5299D72F.7060902@gmx.at> (raw)
In-Reply-To: <jwvob54gx2t.fsf-monnier+emacs@gnu.org>
> But the problem remains of what to do with a C-g interrupting a unwind
> form: in the case of an Fset_window_configuration in an unwind form, the
> intention is to make that "no matter what happens, we end up recovering
> the original state", but a C-g at the wrong time will break this promise.
I'm afraid that C-g at the wrong time might produce an inconsistent
state which IMO seems more fatal than a non-original state.
> - we used to have a "DOLIST" kind of macro which did the hare/tortoise
> thing in lisp.h. Not sure what happened to it, but I'd rather use
> such a macro then duplicate the corresponding code wherever we have
> such a loop.
Agreed.
> - checking cycles here gives us no guarantee since the caller can do
>
> (set-window-prev-buffers w bufs)
> (setcdr bufs bufs)
>
> and you again end up with a cycle in your window-prev-buffers.
Right. So we'd need a safe implementation of delq and I wouldn't know
how to do that reasonably via DOLIST. I'd rather use a simple routine
to find out whether the original argument list of delq is infinite (if
we think this could be a real problem).
martin
next prev parent reply other threads:[~2013-11-30 12:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 21:15 C-g while exiting the minibuffer Stefan Monnier
2013-11-28 1:54 ` Stefan Monnier
2013-11-28 3:53 ` Eli Zaretskii
2013-11-28 15:14 ` Stefan Monnier
2013-11-28 17:02 ` martin rudalics
2013-11-28 19:22 ` Stefan Monnier
2013-11-28 23:17 ` Andreas Schwab
2013-11-29 1:34 ` Stefan Monnier
2013-11-29 1:38 ` Stefan Monnier
2013-11-30 12:16 ` martin rudalics [this message]
2013-12-01 22:13 ` Stefan Monnier
2013-12-02 3:30 ` Stephen J. Turnbull
2013-12-05 14:02 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5299D72F.7060902@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.