From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers. Date: Fri, 29 Nov 2013 16:53:43 +0200 Message-ID: <5298AA77.4060009@yandex.ru> References: <871u1zes89.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1385736893 25620 80.91.229.3 (29 Nov 2013 14:54:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Nov 2013 14:54:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 29 15:54:58 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VmPT5-0003Ok-8D for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 15:54:55 +0100 Original-Received: from localhost ([::1]:47690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmPT1-0002Ll-UM for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 09:54:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmPS8-0000mw-1S for emacs-devel@gnu.org; Fri, 29 Nov 2013 09:54:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmPRz-0006U9-Kj for emacs-devel@gnu.org; Fri, 29 Nov 2013 09:53:55 -0500 Original-Received: from mail-ea0-x231.google.com ([2a00:1450:4013:c01::231]:35292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmPRz-0006U5-Dj for emacs-devel@gnu.org; Fri, 29 Nov 2013 09:53:47 -0500 Original-Received: by mail-ea0-f177.google.com with SMTP id n15so6843915ead.36 for ; Fri, 29 Nov 2013 06:53:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=mB/qcgHJZmJivMytbUjqQBix07m/Nicr8/gNspy34FE=; b=f+PwGcs3Y7aP9GIhqbaX7nH/j67ukKItT/LYMPal5pG0KZ3gOAIhCQ3Y8Nbh46gyIH KE5rX/mEorS9J8NYeR9Xlq6C/iwYH5c9quGc/6gi6s9Vo7v6FbKvaTpwSj+KjZu4+9jr kt+URPmKUH/ld+WmYp8r2o5DMwJ9IoO0l8wDofJVR2Dgd6uteXBzJPq1f+TJe6vpkd0b XImO42bCJcUoToGWgEflzbJzEaY8LPD1vuwuU93vPsr9NneSDlj+y4jZ/uYKyBTA5X5L Vy5OdK78I+62+iMknTAel6jlIEVuJqwlvmHJ0nDzdE4ecm10wDoyvmCDedKfD7fvrfCV sirw== X-Received: by 10.14.251.68 with SMTP id a44mr2520333ees.64.1385736826154; Fri, 29 Nov 2013 06:53:46 -0800 (PST) Original-Received: from [192.168.10.48] (93-245-142.netrun.cytanet.com.cy. [93.109.245.142]) by mx.google.com with ESMTPSA id g1sm41393257eew.1.2013.11.29.06.53.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 29 Nov 2013 06:53:45 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165875 Archived-At: On 29.11.2013 15:33, Stefan Monnier wrote: > The intention was to remind people that they should think about who's > the author. Indeed, it's particularly useful for us but less so for > many other projects. Isn't it too late to remind when the log-edit buffer is open? Normally, you create ChangeLog entries first (and they should include the right author), only then open the vc-dir buffer, mark the files and then see the log-edit buffer. > Maybe we can set it as a .dir-locals.el customization. It would be better, but since dir-locals overrides personal customizations, it wouldn't be ideal either, as far as I'm concerned. > The RFC822 format does add features, since there are a few other special > headers (Author, Fixes, Amend, maybe a few more). True. But is it relevant to the question of whether to include the Summary and Author headers by default? Another problem with Summary, I believe, is that it's often unused in Emacs commit messages. > We should also use some of the message-mode commands to move inside the > header, as was suggested here recently. Not sure which thread, or which commands you mean. But `C-e' works well enough for moving after "Summary:". > Indeed, that needs to be fixed. It's easy to fix when we kill the > *vc-log* buffer, but it might be trickier to fix when you just > bury-it :( Since bury-buffer doesn't have a default binding in log-edit, I think that's not much of a problem. But we can follow Magit's (and message-mode's) example and create a command that would do the burying the smart way (and bind it to C-c C-k). > Maybe log-edit-show-files shouldn't be in the default log-edit-hook. I'd rather we fix it than hide it. Another approach would be to instead of creating a separate buffer and window, output its text at the bottom of the log-edit buffer. And either make it a read-only-not-real text, or comment it out somehow and remove that section before the commit is made.