Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers.

[Dmitry Gutov <dgutov@yandex.ru>]

On 29.11.2013 15:33, Stefan Monnier wrote:
> The intention was to remind people that they should think about who's
> the author.  Indeed, it's particularly useful for us but less so for
> many other projects.

Isn't it too late to remind when the log-edit buffer is open? Normally, 
you create ChangeLog entries first (and they should include the right 
author), only then open the vc-dir buffer, mark the files and then see 
the log-edit buffer.

> Maybe we can set it as a .dir-locals.el customization.

It would be better, but since dir-locals overrides personal 
customizations, it wouldn't be ideal either, as far as I'm concerned.

> The RFC822 format does add features, since there are a few other special
> headers (Author, Fixes, Amend, maybe a few more).

True. But is it relevant to the question of whether to include the 
Summary and Author headers by default?

Another problem with Summary, I believe, is that it's often unused in 
Emacs commit messages.

> We should also use some of the message-mode commands to move inside the
> header, as was suggested here recently.

Not sure which thread, or which commands you mean. But `C-e' works well 
enough for moving after "Summary:".

 > Indeed, that needs to be fixed.  It's easy to fix when we kill the
 > *vc-log* buffer, but it might be trickier to fix when you just
 > bury-it :(

Since bury-buffer doesn't have a default binding in log-edit, I think 
that's not much of a problem. But we can follow Magit's (and 
message-mode's) example and create a command that would do the burying 
the smart way (and bind it to C-c C-k).

 > Maybe log-edit-show-files shouldn't be in the default log-edit-hook.

I'd rather we fix it than hide it. Another approach would be to instead 
of creating a separate buffer and window, output its text at the bottom 
of the log-edit buffer. And either make it a read-only-not-real text, or 
comment it out somehow and remove that section before the commit is made.