From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#14029: 24.2.50; [PATCH] imenu problems with special elements Date: Fri, 29 Nov 2013 05:43:57 +0200 Message-ID: <52980D7D.2060902@yandex.ru> References: <87hak4gram.fsf@fh-trier.de> <5ABDF35DFCF64DEEAA37AFAE5048578D@us.oracle.com> <87ip4iwfoe.fsf@fh-trier.de> <878v5ew1pp.fsf@fh-trier.de> <87iovhqrve.fsf@yandex.ru> <87vbzhl05s.fsf@hochschule-trier.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1385696719 21931 80.91.229.3 (29 Nov 2013 03:45:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Nov 2013 03:45:19 +0000 (UTC) Cc: 14029-done@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 29 04:45:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VmF19-0004An-Dw for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Nov 2013 04:45:23 +0100 Original-Received: from localhost ([::1]:45301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmF18-0004vP-Vq for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Nov 2013 22:45:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmF0y-0004tp-Nu for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2013 22:45:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmF0q-0008Lc-An for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2013 22:45:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmF0q-0008Kj-5o for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2013 22:45:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VmF0p-00075Q-Bz for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2013 22:45:03 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Nov 2013 03:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14029 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 14029@debbugs.gnu.org, dgutov@yandex.ru, politza@fh-trier.de Original-Received: via spool by 14029-done@debbugs.gnu.org id=D14029.138569665027136 (code D ref 14029); Fri, 29 Nov 2013 03:45:01 +0000 Original-Received: (at 14029-done) by debbugs.gnu.org; 29 Nov 2013 03:44:10 +0000 Original-Received: from localhost ([127.0.0.1]:49478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VmEzx-00073c-LX for submit@debbugs.gnu.org; Thu, 28 Nov 2013 22:44:09 -0500 Original-Received: from mail-wi0-f179.google.com ([209.85.212.179]:63617) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VmEzv-00073G-Du for 14029-done@debbugs.gnu.org; Thu, 28 Nov 2013 22:44:08 -0500 Original-Received: by mail-wi0-f179.google.com with SMTP id ey16so1546326wid.6 for <14029-done@debbugs.gnu.org>; Thu, 28 Nov 2013 19:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=afFf0Yr/9iJsriBqofielcvllurTtep2F/JcHCUgWD4=; b=AxzlAMgPUnVeCZ1dfFOo4JlCb/1PxdLKtQ5CKubWKae3kIpF9hOCcMG/5chw/skRdV 6g6T23BKnXT2gZx0TJI14mKtKvSUxqH6hvkKLZwBZsDKypqv/IqFG4H532yKGJp4ZUnh hV7vLhakzNgTQWMbY7cMuFkJsT/5M2L5IRT1GRPb3FGT5pclSk4jQyAMzb/iCVQ3lOJu fWbyLjcFwkd/d615bBJZj7VFNU0PfxgYhQCOQIixc5K4RXegHcrCNz8jZ0+PNQOF6IUS SoUL0qULvaU5+XnyAfoTsNV46+ggeMnFyGRBemwAnVsJbPEcRu2QG2H+r3DlNpp1G2O3 YpGg== X-Received: by 10.194.93.193 with SMTP id cw1mr8143932wjb.38.1385696641321; Thu, 28 Nov 2013 19:44:01 -0800 (PST) Original-Received: from [192.168.10.2] (83-43-131.netrun.cytanet.com.cy. [83.168.43.131]) by mx.google.com with ESMTPSA id w1sm52104810wib.6.2013.11.28.19.43.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 28 Nov 2013 19:44:00 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 In-Reply-To: <87vbzhl05s.fsf@hochschule-trier.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81072 Archived-At: Version: 24.4 Thanks, that's clearer. Installed in revision 115279. One note: >> Is it possible for (cadr item) to be a list and also be `functionp' and yet not >> have its car be `lambda'? Dunno. I was under the impression that it was >> impossible, but I could be wrong. If it is possible, is it better to test >> `functionp' here? Dunno. > > If the documentation states FUNCTION, then it should be a function. The documentation allows FUNCTION in the third element, but `imenu--subalist-p' is checking whether the second element is a function. AFAICT, it's checking against malformed items. Your change makes it also guard against lexically-bound lambdas (their car is `closure'), so that's good, I guess.