From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ryan Newsgroups: gmane.emacs.devel Subject: Re: Improvements to adjust-parens Date: Mon, 25 Nov 2013 17:52:59 -0800 Message-ID: <5293FEFB.3000104@thompsonclan.org> References: <5293C972.2020605@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1385437076 21871 80.91.229.3 (26 Nov 2013 03:37:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Nov 2013 03:37:56 +0000 (UTC) Cc: emacs-devel@gnu.org To: Barry OReilly Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 26 04:38:01 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vl9TM-0006m1-FA for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2013 04:38:00 +0100 Original-Received: from localhost ([::1]:56164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl9TL-0000xJ-QI for ged-emacs-devel@m.gmane.org; Mon, 25 Nov 2013 22:37:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl7pw-0007ug-1p for emacs-devel@gnu.org; Mon, 25 Nov 2013 20:53:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vl7po-0005AQ-Nr for emacs-devel@gnu.org; Mon, 25 Nov 2013 20:53:12 -0500 Original-Received: from mail-pb0-f41.google.com ([209.85.160.41]:58215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl7po-0005AE-HF for emacs-devel@gnu.org; Mon, 25 Nov 2013 20:53:04 -0500 Original-Received: by mail-pb0-f41.google.com with SMTP id jt11so7070481pbb.0 for ; Mon, 25 Nov 2013 17:53:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=rsBTU1QTckoKuJF/2bWsFjSS2ECGEwQxF21+gRmvdbY=; b=OyKa5aRbESA9dUkqLqCjaATmILzKOu7vmYu1pzBloTY8LpH4mapXJC5CNpQr4MtUu1 41rFevI4T6k+agCn4E3v0AOpgQb8JWqnNTe5OUUGe3d4uNpP/mAYp+7JZ9tnCdBWA7ye vSaa/H38RhFmNn7FQh3yHuBvajQnUl10Qc7rSAztuHYkAZc8uU4Ug9zcB13cP/WuQmpY /s26sPy1fgy2cnVGgdx6lTicaupdcnW2Q7t1Gkgv7Q5WtKvp2H8WFux3BHm1RvdSxyRQ F4bwvERXAAFdGNgY7XEra+CjLiX+5+LVOg1I/OobB/TOFx4lXt3PV9s6jopvL+BWUquH WjUw== X-Gm-Message-State: ALoCoQlQOl1AnwRgPhujOE1pGTAYTHhp2y6fwCbQVQMCwIvnMcOwFbdnyBO4HRHrTpo0/7z3LUcE X-Received: by 10.68.245.227 with SMTP id xr3mr4501243pbc.182.1385430782889; Mon, 25 Nov 2013 17:53:02 -0800 (PST) Original-Received: from [192.168.10.2] (user-0c9ha1q.cable.mindspring.com. [24.152.168.58]) by mx.google.com with ESMTPSA id g6sm78325761pat.2.2013.11.25.17.53.00 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Nov 2013 17:53:01 -0800 (PST) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.41 X-Mailman-Approved-At: Mon, 25 Nov 2013 22:37:57 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165738 Archived-At: I believe I have already completed the copyright assignment. On Mon Nov 25 17:51:54 2013, Barry OReilly wrote: > > I have recently started to use your adjust-parens package for > Emacs. I have made a few changes to my copy that I thought you > might want to incorporate upstream. I have attached a patch of all > my changes; below are the ChangeLog entries for my changes (also > inclued in the patch): > > * adjust-parens.el (adjust-parens-mode): Convert to minor mode > (global-adjust-parens-mode): Add globalized mode. Uses a custom > var to determine which modes to enable the mode in. > (adjust-parens-p): Only adjust parens after fixing indentation and > moving point to end of indentation. > (adjust-parens-and-indent): Correct handling of prefix arg. Now > only explicit numeric prefix arguments (i.e. not `C-u') affect the > number of parens adjusted, and negative & zero prefix are handled > correctly. > > * adjust-parens-tests.el (apt-mode-test): Add tests for minor mode > enabling/disabling > (apt-indent-dedent-test): Add tests for behavior when indentation > is incorrect or point is not at end of indentation > > The to main changes of interest are the conversion of > adjust-parens into a minor mode that can be enabled and disabled, > and the changing the initial behavior of the TAB key when the > current line is wrongly indented or the point is at the wrong > position. I hope you find this patch useful. Please let me know > what you think of it. > > > Thanks. adjust-parens is in ELPA which requires a copyright assignment > to FSF for non tiny changes. I'm not sure how to check whether you're > on the list of those who have completed the paperwork. >