From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jarek Czekalski Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * lisp/subr.el (string-suffix-p): New function. Date: Fri, 22 Nov 2013 16:06:55 +0100 Message-ID: <528F730F.5050302@poczta.onet.pl> References: <96EB3F8805134461A3BA58983F643449@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1385132837 26543 80.91.229.3 (22 Nov 2013 15:07:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Nov 2013 15:07:17 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 22 16:07:19 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VjsKC-00082D-Kl for ged-emacs-devel@m.gmane.org; Fri, 22 Nov 2013 16:07:16 +0100 Original-Received: from localhost ([::1]:39359 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjsKC-0006Yk-5y for ged-emacs-devel@m.gmane.org; Fri, 22 Nov 2013 10:07:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjsK3-0006YK-JA for emacs-devel@gnu.org; Fri, 22 Nov 2013 10:07:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjsJt-0004en-8e for emacs-devel@gnu.org; Fri, 22 Nov 2013 10:07:07 -0500 Original-Received: from smtpo56.poczta.onet.pl ([213.180.142.187]:39828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjsJs-0004eO-UA for emacs-devel@gnu.org; Fri, 22 Nov 2013 10:06:57 -0500 Original-Received: from [192.168.17.9] (cj.e-siemianowice.pl [95.215.234.30]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jarekczek@poczta.onet.pl) by smtp.poczta.onet.pl (Onet) with ESMTPSA id 3dR1FW1PpCzZCdhF for ; Fri, 22 Nov 2013 16:06:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poczta.onet.pl; s=2011; t=1385132815; bh=ATsIgmsi+82u1AuOMHd+9KFdZQFYwPTbww+KHx1k3UY=; h=Message-ID:Date:From:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=byT9WCHfH1qne9PqXmrww0xZ5dL+xWUleB5B+2La/0LS8z9TUiXuN5HMIJ8/ac6b0 88xGUaRasmDcyZHkp7nUyuVnGKN6MWrxm6Nu7pu8E314dFXH9eRUIYdVj3YjjrEGMr 2ShPdn8y+PBdoD7I1EFimny868hPwDBgJDQA8PSA= User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120824 Thunderbird/15.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 213.180.142.187 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165563 Archived-At: W dniu 2013-11-22 08:06, Bozhidar Batsov pisze: > No comments == no objections? :-) > +1 for your idea of adding several string functions. I see the following benefits: 1. Improvement of code readability, when using these functions. 2. Easier learning of Elisp, by making string manipulations easier to find. What stands on the other side? What are the disadvantages of introducing Bozhidar's functions as built-ins? I see some opinions that are to discourage Bozhidar without giving explicit reasons. Using "helpers.el" seems to preserve the first advantage, while losing the second. Jarek