From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#13594: 24.2.92; [PATCH] compilation-start doesn't consider nil OUTWIN Date: Sun, 17 Nov 2013 10:48:16 +0100 Message-ID: <528890E0.60204@gmx.at> References: <87sj5apclq.fsf@mail.jurta.org> <87r4ktoinh.fsf@mail.jurta.org> <87mwvhxehw.fsf@mail.jurta.org> <87zjzfz0nq.fsf@mail.jurta.org> <51161554.9010609@gmx.at> <8738x4o5cp.fsf@mail.jurta.org> <5117D9B5.5090203@gmx.at> <87pq07b4k4.fsf@mail.jurta.org> <51192ADD.9010607@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1384681760 13919 80.91.229.3 (17 Nov 2013 09:49:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Nov 2013 09:49:20 +0000 (UTC) Cc: 13594@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 17 10:49:24 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vhyyl-0007YL-H5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2013 10:49:19 +0100 Original-Received: from localhost ([::1]:38430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhyyl-0003UQ-5D for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2013 04:49:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhyyb-0003UF-Bj for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2013 04:49:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhyyU-0005I0-0p for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2013 04:49:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhyyT-0005Hu-T6 for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2013 04:49:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VhyyT-0005Um-Kt for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2013 04:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2013 09:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13594 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13594-submit@debbugs.gnu.org id=B13594.138468171221086 (code B ref 13594); Sun, 17 Nov 2013 09:49:01 +0000 Original-Received: (at 13594) by debbugs.gnu.org; 17 Nov 2013 09:48:32 +0000 Original-Received: from localhost ([127.0.0.1]:58102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhyxz-0005U2-LC for submit@debbugs.gnu.org; Sun, 17 Nov 2013 04:48:31 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:57591) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhyxx-0005Tj-96 for 13594@debbugs.gnu.org; Sun, 17 Nov 2013 04:48:30 -0500 Original-Received: from [62.47.52.90] ([62.47.52.90]) by mail.gmx.com (mrgmx102) with ESMTPA (Nemesis) id 0MSHax-1W77W92anD-00TTtM for <13594@debbugs.gnu.org>; Sun, 17 Nov 2013 10:48:22 +0100 In-Reply-To: X-Provags-ID: V03:K0:4/jY65zOdS24w8xD1hfO8syutHB/vcYNIiU/wBAE/DcAvmhWBVt ypv0n3drWUrI7wJbTvT/DJQx/GQdw/1Ry85V1OulDqHHoPd5K6GHgjSgaGG81aswlBL9o+x vqRann79kOZLtBW0aybStdwyabBRWG8KQY7nXTG/yVCigC27HBgdDL6jvYY4BDk+5pvblrH vkcEo6nFm78K3VmmfpGqA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80681 Archived-At: >> That's one possibility, yes. Tho adding an argument doesn't sound >> much fun. So I'd prefer if it could be passed via ACTION. > > I have read this bug thread again. I am confused by this decision. Why > do we want to tell display-buffer to do nothing (via ACTION or extra > arg) when we can choose not to call it? Isn't not calling it better? Stefan proposes to handle the case where the application wants to display the buffer but `display-buffer' is not able to do so. Ever since, all callers of `display-buffer' I know of silently assumed that the latter would display the buffer and return its window despite the fact that it was possible that the buffer would not get displayed. Stefan's proposal would correct that misunderstanding although now these might result from the fact that if no argument is "passed via ACTION", `display-buffer' could use the selected window, harming an application's assumptions provided via setting inhibit-same-window to non-nil. We at least would have to document such fact but it's an "incompatible change" nevertheless. I think this is a minor evil and should be fairly rare as well. Now if an application and/or user do not want to display the buffer in the first case, `display-buffer' should not be called. If, however, the call cannot be avoided, we should add a second (user) action which avoids entering the loop in `display-buffer' and returns nil immediately provided the first action was set (that is, the calling application at least pretends to know how to handle a nil return value). martin