From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Subject: [PATCH] * lisp/progmodes/ruby-mode.el: Set `ruby-insert-encoding-magic-comment' to nil by default. Date: Sun, 03 Nov 2013 00:15:30 +0400 Message-ID: <52755D62.1070700@yandex.ru> References: <61BBE6C8D4D349B6963A0F429237A3A8@gmail.com> <87txfvad0a.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1383423342 27492 80.91.229.3 (2 Nov 2013 20:15:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Nov 2013 20:15:42 +0000 (UTC) Cc: emacs-devel To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 02 21:15:48 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vchbn-0004jP-Pq for ged-emacs-devel@m.gmane.org; Sat, 02 Nov 2013 21:15:47 +0100 Original-Received: from localhost ([::1]:43056 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vchbn-0004iW-6x for ged-emacs-devel@m.gmane.org; Sat, 02 Nov 2013 16:15:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vchbf-0004iL-TV for emacs-devel@gnu.org; Sat, 02 Nov 2013 16:15:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vchba-0001Jv-0y for emacs-devel@gnu.org; Sat, 02 Nov 2013 16:15:39 -0400 Original-Received: from mail-la0-x232.google.com ([2a00:1450:4010:c03::232]:37610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VchbZ-0001Jp-M7 for emacs-devel@gnu.org; Sat, 02 Nov 2013 16:15:33 -0400 Original-Received: by mail-la0-f50.google.com with SMTP id eo20so896369lab.23 for ; Sat, 02 Nov 2013 13:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=hM9oVggMm1UPQvBEYUafbMGtSNXV34OrH2YNvciZ9nU=; b=DrL1Li4Ki0pUvHoaR3MCmv0z4WtuXFPuaxprvnG9BM28A7QlNS+SY8Sh136++7G6U1 qzxFgRPZaFT3qdBfqeA7KNiGXV/q7K3FF/Qv++h13he25HgRubdICz8Tqf7K18wso9Hk y28ep/wKfaQVFxicNZkleMzh21wdB+1kU2ACpm9pOi3k4oljFLe5un0QKA0Y0TA2Mwyg VAmcG3QMR4fBmahYOmC9b7t0YJ8mjvyRHAH1gbjtAE3L+5/Pa6ZtN/C11xQOZ7HZn0uv PU2TXh/DnP7Jcw9Js26SIlDtGzn4vHC8rHAx7Hukb26y9zBOI92Odr8dkZmATU6kIVCx eRnw== X-Received: by 10.152.171.72 with SMTP id as8mr638395lac.33.1383423332522; Sat, 02 Nov 2013 13:15:32 -0700 (PDT) Original-Received: from [192.168.1.3] ([178.252.98.87]) by mx.google.com with ESMTPSA id i3sm10087032laf.10.2013.11.02.13.15.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 02 Nov 2013 13:15:31 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164879 Archived-At: On 02.11.2013 14:38, Bozhidar Batsov wrote: > Also see > http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00236.html > > > Disabling this by default is not directly related to improving it. While > I think your suggestions for running this in an after-save-hook are > sound, I feel that the majority of Ruby programmers out there no longer > need this, so it doesn't make sense to have it on by default just to > make people search how to disable it (unless it stops messing with files > that are already using utf-8, which as you note is problematic for users > of Ruby 1.9). I don't understand what you mean with the sentence in parentheses. Ruby 1.9 still requires "coding: utf-8" cookies in unicode files that have non-ascii characters. There was a problem with inserting it ("coding: unknown" was often inserted instead), but that has been fixed. > P.S. I also think we should insert the comment in Ruby style (e.g. "# > encoding: utf-8") instead of the current Emacs style encoding comment > (or make this customizable). Maybe. I'm not sure what would be the benefit, but it sounds fine to me.