From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jarek Czekalski Newsgroups: gmane.emacs.devel Subject: patch: create default error output function Date: Fri, 01 Nov 2013 21:18:25 +0100 Message-ID: <52740C91.3000305@poczta.onet.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------030904040903090501070601" X-Trace: ger.gmane.org 1383333429 2113 80.91.229.3 (1 Nov 2013 19:17:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Nov 2013 19:17:09 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 01 20:17:14 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VcKDY-0006A0-6H for ged-emacs-devel@m.gmane.org; Fri, 01 Nov 2013 20:17:12 +0100 Original-Received: from localhost ([::1]:39566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcKDX-0008Mt-N0 for ged-emacs-devel@m.gmane.org; Fri, 01 Nov 2013 15:17:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcKDP-0008Ln-3O for emacs-devel@gnu.org; Fri, 01 Nov 2013 15:17:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VcKDK-0001gS-2J for emacs-devel@gnu.org; Fri, 01 Nov 2013 15:17:03 -0400 Original-Received: from smtpo11.poczta.onet.pl ([213.180.142.142]:35447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcKDJ-0001gG-Hl for emacs-devel@gnu.org; Fri, 01 Nov 2013 15:16:57 -0400 Original-Received: from [192.168.17.5] (cj.e-siemianowice.pl [95.215.234.30]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jarekczek@poczta.onet.pl) by smtp.poczta.onet.pl (Onet) with ESMTPSA id 3dBCnf5Clqz9v90v for ; Fri, 1 Nov 2013 20:16:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poczta.onet.pl; s=2011; t=1383333414; bh=Y5392neBlK5uPloPYuWRgg8Fv42W4Dkzi5JneAWzV30=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type; b=AlGwBCwuXyaaMenEylEYvTMxWdN05uQcVvVpXimg/P8K+lY3cqWdknhNk/MOzhaFK n8nqgzfqXNrfWbi+x79mL/K0+rjHY1Ebha5+vQoWU+TDIp04oEhFek59S1pNUEOURF eTiv4MziQH+bn7l2RZlZVZ0Gsaq1sxVa27MrLP08= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 213.180.142.142 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164824 Archived-At: This is a multi-part message in MIME format. --------------030904040903090501070601 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit As suggested by Stefan in [1] I prepared a patch that creates a new elisp function which makes a default value for command-error-function. This makes it possible to use this variable by packages. Patch is against r114884. Please review and comment my first Emacs patch. I couldn't find any guide for submitting patches, so I based it on my intuition and experience from previous projects, mainly jEdit. Sometimes it's better to have a ticket in the tracker for a patch for easy reference to a discussion from a commit log message. But in gnu they say about posting a patch to the list, so I post. Thanks, Jarek [1] http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00807.html --------------030904040903090501070601 Content-Type: text/plain; charset=ISO-8859-1; name="cmd_err_1_04.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="cmd_err_1_04.txt" PT09IG1vZGlmaWVkIGZpbGUgJ0NoYW5nZUxvZycKLS0tIENoYW5nZUxvZwkyMDEzLTEwLTMx IDIxOjM5OjEwICswMDAwCisrKyBDaGFuZ2VMb2cJMjAxMy0xMS0wMSAxOTozNjo1OCArMDAw MApAQCAtMSwzICsxLDggQEAKKzIwMTMtMTEtMDEgIEphcmVrIEN6ZWthbHNraSAgPGphcmVr Y3pla0Bwb2N6dGEub25ldC5wbD4KKworCSoga2V5Ym9hcmQuYzogbmV3IGZ1bmN0aW9uIGRl ZmF1bHQtZXJyb3Itb3V0cHV0IHdoaWNoIGJlY29tZXMKKwlhIGRlZmF1bHQgdmFsdWUgZm9y IGNvbW1hbmQtZXJyb3ItZnVuY3Rpb24uCisKIDIwMTMtMTAtMzEgIEdsZW5uIE1vcnJpcyAg PHJnbUBnbnUub3JnPgogCiAJKiBjb25maWd1cmUuYWM6IFVzZSBbIS4uLl0gcmF0aGVyIHRo YW4gW14uLi5dLCBmb3Iga3NoLiAgKEJ1ZyMxNTc2OSkKCj09PSBtb2RpZmllZCBmaWxlICdz cmMva2V5Ym9hcmQuYycKLS0tIHNyYy9rZXlib2FyZC5jCTIwMTMtMTAtMjkgMjE6MDU6MzUg KzAwMDAKKysrIHNyYy9rZXlib2FyZC5jCTIwMTMtMTEtMDEgMTk6NDY6NTEgKzAwMDAKQEAg LTI0MSw2ICsyNDEsOCBAQAogCiBzdGF0aWMgTGlzcF9PYmplY3QgUWVjaG9fYXJlYV9jbGVh cl9ob29rOwogCitzdGF0aWMgTGlzcF9PYmplY3QgUWRlZmF1bHRfZXJyb3Jfb3V0cHV0Owor CiAvKiBIb29rcyB0byBydW4gYmVmb3JlIGFuZCBhZnRlciBlYWNoIGNvbW1hbmQuICAqLwog c3RhdGljIExpc3BfT2JqZWN0IFFwcmVfY29tbWFuZF9ob29rOwogc3RhdGljIExpc3BfT2Jq ZWN0IFFwb3N0X2NvbW1hbmRfaG9vazsKQEAgLTEwNTMsMzUgKzEwNTUsMjEgQEAKICAgcmV0 dXJuIG1ha2VfbnVtYmVyICgwKTsKIH0KIAotLyogVGFrZSBhY3Rpb25zIG9uIGhhbmRsaW5n IGFuIGVycm9yLiAgREFUQSBpcyB0aGUgZGF0YSB0aGF0IGRlc2NyaWJlcwotICAgdGhlIGVy cm9yLgotCi0gICBDT05URVhUIGlzIGEgQy1zdHJpbmcgY29udGFpbmluZyBBU0NJSSBjaGFy YWN0ZXJzIG9ubHkgd2hpY2gKLSAgIGRlc2NyaWJlcyB0aGUgY29udGV4dCBpbiB3aGljaCB0 aGUgZXJyb3IgaGFwcGVuZWQuICBJZiB3ZSBuZWVkIHRvCi0gICBnZW5lcmFsaXplIENPTlRF WFQgdG8gYWxsb3cgbXVsdGlieXRlIGNoYXJhY3RlcnMsIG1ha2UgaXQgYSBMaXNwCi0gICBz dHJpbmcuICAqLwotCi12b2lkCi1jbWRfZXJyb3JfaW50ZXJuYWwgKExpc3BfT2JqZWN0IGRh dGEsIGNvbnN0IGNoYXIgKmNvbnRleHQpCitERUZVTiAoImRlZmF1bHQtZXJyb3Itb3V0cHV0 IiwgRmRlZmF1bHRfZXJyb3Jfb3V0cHV0LAorICAgICAgIFNkZWZhdWx0X2Vycm9yX291dHB1 dCwgMywgMywgMCwKKyAgICAgICBkb2M6IC8qIFByb2R1Y2UgZGVmYXVsdCBvdXRwdXQgZm9y IHRoZSBlcnJvciBtZXNzYWdlLAoraW50byB0aGUgbWVzc2FnZXMgYnVmZmVyIGFuZCB0aGUg ZWNobyBhcmVhLiAgKi8pCisgIChMaXNwX09iamVjdCBkYXRhLCBMaXNwX09iamVjdCBjb250 ZXh0LCBMaXNwX09iamVjdCBzaWduYWwpCiB7CiAgIHN0cnVjdCBmcmFtZSAqc2YgPSBTRUxF Q1RFRF9GUkFNRSAoKTsKLQotICAvKiBUaGUgaW1tZWRpYXRlIGNvbnRleHQgaXMgbm90IGlu dGVyZXN0aW5nIGZvciBRdWl0cywKLSAgICAgc2luY2UgdGhleSBhcmUgYXN5bmNocm9ub3Vz LiAgKi8KLSAgaWYgKEVRIChYQ0FSIChkYXRhKSwgUXF1aXQpKQotICAgIFZzaWduYWxpbmdf ZnVuY3Rpb24gPSBRbmlsOwotCi0gIFZxdWl0X2ZsYWcgPSBRbmlsOwotICBWaW5oaWJpdF9x dWl0ID0gUXQ7Ci0KLSAgLyogVXNlIHVzZXIncyBzcGVjaWZpZWQgb3V0cHV0IGZ1bmN0aW9u IGlmIGFueS4gICovCi0gIGlmICghTklMUCAoVmNvbW1hbmRfZXJyb3JfZnVuY3Rpb24pKQot ICAgIGNhbGwzIChWY29tbWFuZF9lcnJvcl9mdW5jdGlvbiwgZGF0YSwKLQkgICBjb250ZXh0 ID8gYnVpbGRfc3RyaW5nIChjb250ZXh0KSA6IGVtcHR5X3VuaWJ5dGVfc3RyaW5nLAotCSAg IFZzaWduYWxpbmdfZnVuY3Rpb24pOworICBjb25zdCBjaGFyICpzel9jb250ZXh0OworCisg IENIRUNLX1NUUklORyhjb250ZXh0KTsKKyAgc3pfY29udGV4dCA9IFhTVFJJTkcoY29udGV4 dCktPmRhdGE7CisKICAgLyogSWYgdGhlIHdpbmRvdyBzeXN0ZW0gb3IgdGVybWluYWwgZnJh bWUgaGFzbid0IGJlZW4gaW5pdGlhbGl6ZWQKICAgICAgeWV0LCBvciB3ZSdyZSBub3QgaW50 ZXJhY3RpdmUsIHdyaXRlIHRoZSBtZXNzYWdlIHRvIHN0ZGVyciBhbmQgZXhpdC4gICovCi0g IGVsc2UgaWYgKCFzZi0+Z2x5cGhzX2luaXRpYWxpemVkX3AKKyAgaWYgKCFzZi0+Z2x5cGhz X2luaXRpYWxpemVkX3AKIAkgICAvKiBUaGUgaW5pdGlhbCBmcmFtZSBpcyBhIHNwZWNpYWwg bm9uLWRpc3BsYXlpbmcgZnJhbWUuIEl0CiAJICAgICAgd2lsbCBiZSBjdXJyZW50IGluIGRh ZW1vbiBtb2RlIHdoZW4gdGhlcmUgYXJlIG5vIGZyYW1lcwogCSAgICAgIHRvIGRpc3BsYXks IGFuZCBpbiBub24tZGFlbW9uIG1vZGUgYmVmb3JlIHRoZSByZWFsIGZyYW1lCkBAIC0xMDk2 LDcgKzEwODQsNyBAQAogCSAgIHx8IG5vbmludGVyYWN0aXZlKQogICAgIHsKICAgICAgIHBy aW50X2Vycm9yX21lc3NhZ2UgKGRhdGEsIFFleHRlcm5hbF9kZWJ1Z2dpbmdfb3V0cHV0LAot CQkJICAgY29udGV4dCwgVnNpZ25hbGluZ19mdW5jdGlvbik7CisJCQkgICBzel9jb250ZXh0 LCBzaWduYWwpOwogICAgICAgRnRlcnByaSAoUWV4dGVybmFsX2RlYnVnZ2luZ19vdXRwdXQp OwogICAgICAgRmtpbGxfZW1hY3MgKG1ha2VfbnVtYmVyICgtMSkpOwogICAgIH0KQEAgLTEx MDcsOCArMTA5NSwzNSBAQAogICAgICAgbWVzc2FnZV9sb2dfbWF5YmVfbmV3bGluZSAoKTsK ICAgICAgIGJpdGNoX2F0X3VzZXIgKCk7CiAKLSAgICAgIHByaW50X2Vycm9yX21lc3NhZ2Ug KGRhdGEsIFF0LCBjb250ZXh0LCBWc2lnbmFsaW5nX2Z1bmN0aW9uKTsKKyAgICAgIHByaW50 X2Vycm9yX21lc3NhZ2UgKGRhdGEsIFF0LCBzel9jb250ZXh0LCBzaWduYWwpOwogICAgIH0K K30KKworLyogVGFrZSBhY3Rpb25zIG9uIGhhbmRsaW5nIGFuIGVycm9yLiAgREFUQSBpcyB0 aGUgZGF0YSB0aGF0IGRlc2NyaWJlcworICAgdGhlIGVycm9yLgorCisgICBDT05URVhUIGlz IGEgQy1zdHJpbmcgY29udGFpbmluZyBBU0NJSSBjaGFyYWN0ZXJzIG9ubHkgd2hpY2gKKyAg IGRlc2NyaWJlcyB0aGUgY29udGV4dCBpbiB3aGljaCB0aGUgZXJyb3IgaGFwcGVuZWQuICBJ ZiB3ZSBuZWVkIHRvCisgICBnZW5lcmFsaXplIENPTlRFWFQgdG8gYWxsb3cgbXVsdGlieXRl IGNoYXJhY3RlcnMsIG1ha2UgaXQgYSBMaXNwCisgICBzdHJpbmcuICAqLworCit2b2lkCitj bWRfZXJyb3JfaW50ZXJuYWwgKExpc3BfT2JqZWN0IGRhdGEsIGNvbnN0IGNoYXIgKmNvbnRl eHQpCit7CisgIExpc3BfT2JqZWN0IFZjb250ZXh0OworICAvKiBUaGUgaW1tZWRpYXRlIGNv bnRleHQgaXMgbm90IGludGVyZXN0aW5nIGZvciBRdWl0cywKKyAgICAgc2luY2UgdGhleSBh cmUgYXN5bmNocm9ub3VzLiAgKi8KKyAgaWYgKEVRIChYQ0FSIChkYXRhKSwgUXF1aXQpKQor ICAgIFZzaWduYWxpbmdfZnVuY3Rpb24gPSBRbmlsOworCisgIFZxdWl0X2ZsYWcgPSBRbmls OworICBWaW5oaWJpdF9xdWl0ID0gUXQ7CisgIFZjb250ZXh0ID0gY29udGV4dCA/IGJ1aWxk X3N0cmluZyAoY29udGV4dCkgOiBlbXB0eV91bmlieXRlX3N0cmluZzsKKworICAvKiBVc2Ug dXNlcidzIHNwZWNpZmllZCBvdXRwdXQgZnVuY3Rpb24sCisgICAgIGluaXRpYWxseSBpdCBp cyBvdXIgRmRlZmF1bHRfZXJyb3Jfb3V0cHV0LiAgKi8KKyAgaWYgKCFOSUxQIChWY29tbWFu ZF9lcnJvcl9mdW5jdGlvbikpCisgICAgY2FsbDMgKFZjb21tYW5kX2Vycm9yX2Z1bmN0aW9u LCBkYXRhLCBWY29udGV4dCwgVnNpZ25hbGluZ19mdW5jdGlvbik7CiAKICAgVnNpZ25hbGlu Z19mdW5jdGlvbiA9IFFuaWw7CiB9CkBAIC0xMTEwOCw2ICsxMTEyMyw3IEBACiAgIGRlZnN1 YnIgKCZTYWJvcnRfcmVjdXJzaXZlX2VkaXQpOwogICBkZWZzdWJyICgmU2V4aXRfcmVjdXJz aXZlX2VkaXQpOwogICBkZWZzdWJyICgmU3JlY3Vyc2lvbl9kZXB0aCk7CisgIGRlZnN1YnIg KCZTZGVmYXVsdF9lcnJvcl9vdXRwdXQpOwogICBkZWZzdWJyICgmU3RvcF9sZXZlbCk7CiAg IGRlZnN1YnIgKCZTZGlzY2FyZF9pbnB1dCk7CiAgIGRlZnN1YnIgKCZTb3Blbl9kcmliYmxl X2ZpbGUpOwpAQCAtMTE1ODYsMTQgKzExNjAyLDE4IEBACiBwZWN1bGlhciBraW5kIG9mIHF1 aXR0aW5nLiAgKi8pOwogICBWdGhyb3dfb25faW5wdXQgPSBRbmlsOwogCisgIERFRlNZTSAo UWRlZmF1bHRfZXJyb3Jfb3V0cHV0LCAiZGVmYXVsdC1lcnJvci1vdXRwdXQiKTsKICAgREVG VkFSX0xJU1AgKCJjb21tYW5kLWVycm9yLWZ1bmN0aW9uIiwgVmNvbW1hbmRfZXJyb3JfZnVu Y3Rpb24sCiAJICAgICAgIGRvYzogLyogSWYgbm9uLW5pbCwgZnVuY3Rpb24gdG8gb3V0cHV0 IGVycm9yIG1lc3NhZ2VzLgogVGhlIGFyZ3VtZW50cyBhcmUgdGhlIGVycm9yIGRhdGEsIGEg bGlzdCBvZiB0aGUgZm9ybQogIChTSUdOQUxFRC1DT05ESVRJT05TIC4gU0lHTkFMLURBVEEp CiBzdWNoIGFzIGp1c3QgYXMgYGNvbmRpdGlvbi1jYXNlJyB3b3VsZCBiaW5kIGl0cyB2YXJp YWJsZSB0bywKIHRoZSBjb250ZXh0IChhIHN0cmluZyB3aGljaCBub3JtYWxseSBnb2VzIGF0 IHRoZSBzdGFydCBvZiB0aGUgbWVzc2FnZSksCi1hbmQgdGhlIExpc3AgZnVuY3Rpb24gd2l0 aGluIHdoaWNoIHRoZSBlcnJvciB3YXMgc2lnbmFsZWQuICAqLyk7Ci0gIFZjb21tYW5kX2Vy cm9yX2Z1bmN0aW9uID0gUW5pbDsKK2FuZCB0aGUgTGlzcCBmdW5jdGlvbiB3aXRoaW4gd2hp Y2ggdGhlIGVycm9yIHdhcyBzaWduYWxlZC4KKworVGhpcyB2YXJpYWJsZSBpcyBpbml0aWFs aXplZCB3aXRoIEVtYWNzIGRlZmF1bHQgZXJyb3Igb3V0cHV0IGZ1bmN0aW9uLgorSXQgaXMg c3VnZ2VzdGVkIHRoYXQgdXNlciBmdW5jdGlvbnMgYXJlIGFkZGVkIHVzaW5nIGFkZC1mdW5j dGlvbi4gICovKTsKKyAgVmNvbW1hbmRfZXJyb3JfZnVuY3Rpb24gPSBRZGVmYXVsdF9lcnJv cl9vdXRwdXQ7CiAKICAgREVGVkFSX0xJU1AgKCJlbmFibGUtZGlzYWJsZWQtbWVudXMtYW5k LWJ1dHRvbnMiLAogCSAgICAgICBWZW5hYmxlX2Rpc2FibGVkX21lbnVzX2FuZF9idXR0b25z LAoK --------------030904040903090501070601--