From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: Redisplay: NS port, high CPU load Date: Fri, 10 Jun 2016 18:16:39 +1000 Message-ID: <525668A8-4B0E-4791-A423-F1D4903F4511@gmail.com> References: <9793F9E3-979A-4888-8662-F6E0C27C8B37@gmail.com> <20160608195552.GA66865@breton.holly.idiocy.org> <7B0CAF99-689D-4128-8E33-7D9BA8F1823E@gmail.com> <41E503B6-5048-4E20-92CE-1FAD4C05A279@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1465546695 6262 80.91.229.3 (10 Jun 2016 08:18:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Jun 2016 08:18:15 +0000 (UTC) Cc: Alan Third , Emacs-Devel devel To: Anders Lindgren , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 10 10:18:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bBHdq-0003Rf-H5 for ged-emacs-devel@m.gmane.org; Fri, 10 Jun 2016 10:18:10 +0200 Original-Received: from localhost ([::1]:38964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBHdp-0005Re-G0 for ged-emacs-devel@m.gmane.org; Fri, 10 Jun 2016 04:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBHce-0005Pz-J3 for emacs-devel@gnu.org; Fri, 10 Jun 2016 04:16:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBHcc-0008I2-MX for emacs-devel@gnu.org; Fri, 10 Jun 2016 04:16:55 -0400 Original-Received: from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]:35161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBHcV-0008GJ-VA; Fri, 10 Jun 2016 04:16:48 -0400 Original-Received: by mail-pf0-x233.google.com with SMTP id c2so21520112pfa.2; Fri, 10 Jun 2016 01:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=RPvWl2m2rz4aUBMFEcPC0gaSLegpZF8iTgFad0tj5Z8=; b=0doAGhk5+8XQe/P9D+X3yF2EGYGGhSpCL6h/hQaD0+PDJTco9PXMzeZ3pqF58uqDKu a6z2uNk9bSMNl1br9SkDco8w1p5iZgXncFAngS+RamvNOisY5qxG+yxmu+Wo8Zg5hSFY r2QJRDiBovdW6VT9ocam2GunVV+rQF+1cFtDmUfTNUAOGDm4eCfEuOXbzqmn1zSHxQ6W dOqTzoZr1JkEkYKptYJKmbov/HhEGhlwUAPo/ncuT834e84q11e8+u74E0D5+Wphae4j US3o7/zx2DAtTEHsMZ5TG5ukNqW6WfoRz7opzGFo5V5uMPoizNhdSF7aG88r7y7sWXQB GIlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=RPvWl2m2rz4aUBMFEcPC0gaSLegpZF8iTgFad0tj5Z8=; b=iLZdyMjf9w2kk4uuh+j9UfgaqSJEew84Cu4YE3yeRLZSb2ba95VpZzl9T4PXrYyBsz YwYzj6BPSltar6ijET7KI+wiQYhghXSoX4uf3cupPz3dJgQNjyt+X3ZSLTJiw7seb/ax /J36Kjyl+9XEEq9Sw1BRV2b3VaL5A3DMefNUurwwGwqBMcjtkQE+GWYea9zfVZ+b5fep tT4GVV8SytchWi9U8N4X8NCWphidtpeWF7gwrOyIAjI191xLbXaaKkVc+znJrWf+5rMB UhhV05Gm7pMmwtEineZW5AARv1eP9zNdkVMyYxT1pflNchxL7WV4lomMxEIQMXoa5Rwk jj7A== X-Gm-Message-State: ALyK8tKc5OBIPgXvKTDfB8US7/6C72z9ZOTPpKc8WoSh6qmkOTBKzrkm/dmb1PZlS4+19w== X-Received: by 10.98.204.5 with SMTP id a5mr935285pfg.37.1465546607081; Fri, 10 Jun 2016 01:16:47 -0700 (PDT) Original-Received: from [10.71.1.48] (cpe-123-100-131-74.pivit.net.au. [123.100.131.74]) by smtp.gmail.com with ESMTPSA id o2sm15429450pfi.85.2016.06.10.01.16.43 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Jun 2016 01:16:45 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204267 Archived-At: On Jun 10, 2016, at 4:02 PM, Anders Lindgren wrote: > I will be away for the weekend, so if you have write access, feel free = to commit it yourself. Otherwise, I can do it at the beginning of next = week. Personally, I think this should go into the emacs-25 branch but we = will have to get that approved from John or Eli. Good, I have checked in the change. Eli, this addresses a high-CPU-load condition on OS X when a = revert-buffer icon is present in the toolbar and the current buffer was = unmodified. This may or may not be the somewhat difficult-to-trace 100% = CPU load bug a lot of us have been seeing on OSX. The functionality of = the utf-8-hfs coding system for the filesystem is preserved is tests. I would suggest to merge this into emacs-25. Also, I would suggest to check whether code like this should indeed = trigger an update_frame_tool_bar. (with-temp-buffer (insert "XXX"))