* Re: [emacs-leuven-theme] diff-index foreground (#2bis) [not found] ` <86mwmytknx.fsf@somewhere.org> @ 2013-09-28 20:17 ` Dmitry Gutov [not found] ` <5247395B.1030602-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Gutov @ 2013-09-28 20:17 UTC (permalink / raw) To: Fabrice Niessen; +Cc: emacs-devel On 27.09.2013 17:16, Fabrice Niessen wrote: > While thinking at it, even if there are still improvements which can be made > (and which I will try to do) to leuven-theme.el, could you commit the current > version into Emacs trunk? Thanks a lot! Sure, no problem, but please keep emacs-devel in Cc, since this kind of discussion belongs there. Could you explain the following additions: - "Version:" header, apparently carrying the date of the commit. - time-stamp-* local variables at the bottom of the file. Melpa does not use the version header (just sets the version to the time of the last commit), and the time-stamp vars just seem useless to me. Shall I remove both of these additions before checking in the new version? ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <5247395B.1030602-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>]
* Re: [emacs-leuven-theme] diff-index foreground (#2bis) [not found] ` <5247395B.1030602-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> @ 2013-10-01 19:56 ` Fabrice Niessen 2013-10-02 3:05 ` Dmitry Gutov 0 siblings, 1 reply; 5+ messages in thread From: Fabrice Niessen @ 2013-10-01 19:56 UTC (permalink / raw) To: Dmitry Gutov; +Cc: emacs-devel Hello Dmitry, Dmitry Gutov wrote: > On 27.09.2013 17:16, Fabrice Niessen wrote: > >> While thinking at it, even if there are still improvements which can be made >> (and which I will try to do) to leuven-theme.el, could you commit the current >> version into Emacs trunk? Thanks a lot! > > Sure, no problem, but please keep emacs-devel in Cc, since this kind of > discussion belongs there. OK. There it is. > Could you explain the following additions: > > - "Version:" header, apparently carrying the date of the commit. The "Version:" header contains the date (and time) of the last `save-file' operation... > - time-stamp-* local variables at the bottom of the file. ... *thanks to* the local variables: ╭──── │ ;; Local Variables: │ ;; time-stamp-format: "%:y%02m%02d.%02H%02M" │ ;; time-stamp-start: "Version: " │ ;; time-stamp-end: "$" │ ;; End: ╰──── This instructs the time-stamp package to update the "Version:" time stamp every time you save the buffer ("last change"), if you have the following in your `.emacs' config file: (add-hook 'before-save-hook 'time-stamp) > Melpa does not use the version header (just sets the version to the time of the > last commit), and the time-stamp vars just seem useless to me. > > Shall I remove both of these additions before checking in the new version? This version number seems useful to me, to always know when different versions have been saved, even outside of any VC system. May I ask to leave them, if possible? Best regards, Fabrice -- Fabrice Niessen Leuven, Belgium ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [emacs-leuven-theme] diff-index foreground (#2bis) 2013-10-01 19:56 ` Fabrice Niessen @ 2013-10-02 3:05 ` Dmitry Gutov [not found] ` <524B8D69.2000100-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> 2013-10-03 3:41 ` Stefan Monnier 0 siblings, 2 replies; 5+ messages in thread From: Dmitry Gutov @ 2013-10-02 3:05 UTC (permalink / raw) To: Fabrice Niessen; +Cc: emacs-devel On 01.10.2013 22:56, Fabrice Niessen wrote: >> - time-stamp-* local variables at the bottom of the file. > > ... *thanks to* the local variables: > > ╭──── > │ ;; Local Variables: > │ ;; time-stamp-format: "%:y%02m%02d.%02H%02M" > │ ;; time-stamp-start: "Version: " > │ ;; time-stamp-end: "$" > │ ;; End: > ╰──── > > This instructs the time-stamp package to update the "Version:" time stamp every > time you save the buffer ("last change"), if you have the following in your > `.emacs' config file: > > (add-hook 'before-save-hook 'time-stamp) I see, thanks for the explanation. >> Melpa does not use the version header (just sets the version to the time of the >> last commit), and the time-stamp vars just seem useless to me. >> >> Shall I remove both of these additions before checking in the new version? > > This version number seems useful to me, to always know when different versions > have been saved, even outside of any VC system. IMHO, the "last save time" alone is pretty useless, so one shouldn't modify important files outside of VS systems. > May I ask to leave them, if possible? Sure, I guess, since it serves some purpose. I don't think we have any guidelines about that. ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <524B8D69.2000100-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>]
* Re: [emacs-leuven-theme] diff-index foreground (#2bis) [not found] ` <524B8D69.2000100-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> @ 2013-10-02 5:06 ` Fabrice Niessen 0 siblings, 0 replies; 5+ messages in thread From: Fabrice Niessen @ 2013-10-02 5:06 UTC (permalink / raw) To: Dmitry Gutov; +Cc: Fabrice Niessen, emacs-devel Hello Dmitry, Dmitry Gutov wrote: > On 01.10.2013 22:56, Fabrice Niessen wrote: >>> - time-stamp-* local variables at the bottom of the file. >> >> ... *thanks to* the local variables: >> >> ╭──── >> │ ;; Local Variables: >> │ ;; time-stamp-format: "%:y%02m%02d.%02H%02M" >> │ ;; time-stamp-start: "Version: " >> │ ;; time-stamp-end: "$" >> │ ;; End: >> ╰──── >> >> This instructs the time-stamp package to update the "Version:" time stamp every >> time you save the buffer ("last change"), if you have the following in your >> `.emacs' config file: >> >> (add-hook 'before-save-hook 'time-stamp) > > I see, thanks for the explanation. > >>> Melpa does not use the version header (just sets the version to the time of the >>> last commit), and the time-stamp vars just seem useless to me. >>> >>> Shall I remove both of these additions before checking in the new version? >> >> This version number seems useful to me, to always know when different versions >> have been saved, even outside of any VC system. > > IMHO, the "last save time" alone is pretty useless, so one shouldn't modify > important files outside of VS systems. I totally agree, but nothing forbids someone to take a "snapshot" version of the leuven-theme.el file from GitHub, without cloning the repository. In case they report a problem, they always can include the version number for information, as it's there. And being almost like an ISO 8601 date, it's very easy to identify versions from the repository. >> May I ask to leave them, if possible? > > Sure, I guess, since it serves some purpose. I don't think we have any > guidelines about that. OK, thanks. Best regards, Fabrice -- Fabrice Niessen Leuven, Belgium ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [emacs-leuven-theme] diff-index foreground (#2bis) 2013-10-02 3:05 ` Dmitry Gutov [not found] ` <524B8D69.2000100-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> @ 2013-10-03 3:41 ` Stefan Monnier 1 sibling, 0 replies; 5+ messages in thread From: Stefan Monnier @ 2013-10-03 3:41 UTC (permalink / raw) To: Dmitry Gutov; +Cc: Fabrice Niessen, emacs-devel >> May I ask to leave them, if possible? > Sure, I guess, since it serves some purpose. I don't think we have any > guidelines about that. We generally don't like $Revision:$, $Date:$, $Log$, and friends like timestamps, because they're sources of gratuitous merge conflicts. But we do not disallow them either, if the author insists on keeping them. Stefan ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-03 3:41 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <fniessen/emacs-leuven-theme/issues/2@github.com> [not found] ` <fniessen/emacs-leuven-theme/issues/2/22233879@github.com> [not found] ` <86ioy9n78u.fsf_-_@somewhere.org> [not found] ` <864n96uzcq.fsf@somewhere.org> [not found] ` <86mwmytknx.fsf@somewhere.org> 2013-09-28 20:17 ` [emacs-leuven-theme] diff-index foreground (#2bis) Dmitry Gutov [not found] ` <5247395B.1030602-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> 2013-10-01 19:56 ` Fabrice Niessen 2013-10-02 3:05 ` Dmitry Gutov [not found] ` <524B8D69.2000100-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org> 2013-10-02 5:06 ` Fabrice Niessen 2013-10-03 3:41 ` Stefan Monnier
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.