From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#15251: 24.3.50; do-auto-fill "continues" comment from inside a string Date: Wed, 02 Oct 2013 03:50:34 +0300 Message-ID: <524B6DDA.3050601@yandex.ru> References: <87ioyisnjx.fsf@yandex.ru> <87y56gwa5m.fsf@yandex.ru> <52482759.1070804@easy-emacs.de> <87wqlzpsj6.fsf@yandex.ru> <524A22E1.5000500@yandex.ru> <524AECFB.80608@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1380675079 15095 80.91.229.3 (2 Oct 2013 00:51:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Oct 2013 00:51:19 +0000 (UTC) Cc: 15251-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 02 02:51:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VRAeu-0002ke-W6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Oct 2013 02:51:21 +0200 Original-Received: from localhost ([::1]:33357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRAeu-0001fy-6K for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2013 20:51:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRAek-0001fh-Dj for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2013 20:51:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRAec-0006ZW-HS for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2013 20:51:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRAec-0006ZR-E4 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2013 20:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VRAec-0002BP-2k for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2013 20:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Oct 2013 00:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15251 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15251-done@debbugs.gnu.org id=D15251.13806750468369 (code D ref 15251); Wed, 02 Oct 2013 00:51:02 +0000 Original-Received: (at 15251-done) by debbugs.gnu.org; 2 Oct 2013 00:50:46 +0000 Original-Received: from localhost ([127.0.0.1]:48229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRAeL-0002Av-Dh for submit@debbugs.gnu.org; Tue, 01 Oct 2013 20:50:45 -0400 Original-Received: from mail-ea0-f181.google.com ([209.85.215.181]:49142) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRAeE-0002Ah-Mg for 15251-done@debbugs.gnu.org; Tue, 01 Oct 2013 20:50:43 -0400 Original-Received: by mail-ea0-f181.google.com with SMTP id d10so43804eaj.12 for <15251-done@debbugs.gnu.org>; Tue, 01 Oct 2013 17:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=mwKwXu0avhSNEr1LQZ5/sS/9NH87Mpi777wJYXlDGkk=; b=jyoAkiVM20P9THq9Uzh8a5gzLIcKkzSCzbFVR7WkMrCilPLHkN9bvOsOycx5MEJHFQ FAL2V49EhU/tTv64QTtv2D4+ashVYTOGh2vLV+4RqDk9dZthLE7QXy2WF7sLwIAEPgiC +qAezsdWr6h78VarI21edVZy0Nwt5wuriSuv5ZdxLXX4bM7HL6VZu8OGD9J4LE3H3Tyv /W1tP+sUv+Bqna+yUAxX2PvkZlslbz4+Wf3OfXb2xQdBo9AyKDO6p5/vmNtBU93E+QTt 7O+xD7RKUn60dRIVZdbaSZOGxNsQHND0p5rfM88DKN5PRzW8gCVUCQ09eAcZUvg2VXlU uoqQ== X-Received: by 10.14.214.136 with SMTP id c8mr49689073eep.6.1380675037706; Tue, 01 Oct 2013 17:50:37 -0700 (PDT) Original-Received: from [192.168.10.2] (62-118-214.netrun.cytanet.com.cy. [62.228.118.214]) by mx.google.com with ESMTPSA id v8sm18936737eeo.12.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Oct 2013 17:50:36 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78846 Archived-At: On 02.10.2013 03:32, Stefan Monnier wrote: > - Change code that uses comment-use-global-state to use (and > comment-use-syntax comment-use-global-state) instead. This is already the case: `comment-search-forward' consults the value of `comment-use-global-state' only when `comment-use-syntax' is truthy. > - Maybe make comment-use-global-state obsolete. > > Context: the problem with syntax-ppss is not so much performance as > correctness, because syntax-ppss can get confused if you use several > syntax-tables in the same buffer (e.g. via font-lock-syntax-table), or > if you use narrowing. Yes, that seems hard to test for. And if `syntax-ppss' can be borked in some modes, using its value in `comment-beginning' like I did in the respective patch, also seems unsafe.