* Re: [Emacs-diffs] trunk r114484: * lisp/emacs-lisp/package-x.el (package-upload-buffer-internal): Pass
[not found] <E1VQMra-0007pP-P1@vcs.savannah.gnu.org>
@ 2013-09-30 18:41 ` Stefan Monnier
2013-09-30 22:32 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2013-09-30 18:41 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
> (declare-function tar-get-file-descriptor "tar-mode" (file))
> (declare-function tar--extract "tar-mode" (descriptor))
> @@ -1180,6 +1207,8 @@
> (reqs (if desc (package-desc-reqs desc)))
> (version (if desc (package-desc-version desc)))
> (archive (if desc (package-desc-archive desc)))
> + (homepage (if desc (cdr (assoc :homepage
> + (package-desc-extras desc)))))
> (built-in (eq pkg-dir 'builtin))
> (installable (and archive (not built-in)))
> (status (if desc (package-desc-status desc) "orphan")))
We already use :url for that in a few packages (currently only used by
the GNU ELPA build scripts for the elpa.gnu.org/packages/*.html pages).
IOW I recommend we use :url rather than :homepage.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Emacs-diffs] trunk r114484: * lisp/emacs-lisp/package-x.el (package-upload-buffer-internal): Pass
2013-09-30 18:41 ` [Emacs-diffs] trunk r114484: * lisp/emacs-lisp/package-x.el (package-upload-buffer-internal): Pass Stefan Monnier
@ 2013-09-30 22:32 ` Dmitry Gutov
2013-10-01 0:55 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2013-09-30 22:32 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On 30.09.2013 21:41, Stefan Monnier wrote:
> We already use :url for that in a few packages (currently only used by
> the GNU ELPA build scripts for the elpa.gnu.org/packages/*.html pages).
> IOW I recommend we use :url rather than :homepage.
Sure, no problem. The reason I went with :homepage is `lm-homepage` is
named that way, and it checks both headers.
Could you point out the file(s) :url is used in? So far the only
relevant match for :url I found is in elpa/packages/README.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] trunk r114484: * lisp/emacs-lisp/package-x.el (package-upload-buffer-internal): Pass
2013-09-30 22:32 ` Dmitry Gutov
@ 2013-10-01 0:55 ` Stefan Monnier
2013-10-01 16:18 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2013-10-01 0:55 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
> Could you point out the file(s) :url is used in? So far the only relevant
> match for :url I found is in elpa/packages/README.
Look for archive--get-prop calls in admin/archive-contents.el.
The call checks both the :url keyword in <foo>-pkg.el as well as "URL:"
pseudo-header in <foo>.el, which is why ":url" doesn't appear in the
file (it's built from "URL" via downcase+format+intern).
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Emacs-diffs] trunk r114484: * lisp/emacs-lisp/package-x.el (package-upload-buffer-internal): Pass
2013-10-01 0:55 ` Stefan Monnier
@ 2013-10-01 16:18 ` Dmitry Gutov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2013-10-01 16:18 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On 01.10.2013 03:55, Stefan Monnier wrote:
>> Could you point out the file(s) :url is used in? So far the only relevant
>> match for :url I found is in elpa/packages/README.
>
> Look for archive--get-prop calls in admin/archive-contents.el.
> The call checks both the :url keyword in <foo>-pkg.el as well as "URL:"
> pseudo-header in <foo>.el, which is why ":url" doesn't appear in the
> file (it's built from "URL" via downcase+format+intern).
See it now, thanks. Since the :url will be included in the pkg vector,
we should be able to replace this `archive--get-prop' call with
appropriate lookup (will post the combined patch later to the relevant bug).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-01 16:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1VQMra-0007pP-P1@vcs.savannah.gnu.org>
2013-09-30 18:41 ` [Emacs-diffs] trunk r114484: * lisp/emacs-lisp/package-x.el (package-upload-buffer-internal): Pass Stefan Monnier
2013-09-30 22:32 ` Dmitry Gutov
2013-10-01 0:55 ` Stefan Monnier
2013-10-01 16:18 ` Dmitry Gutov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.