all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Antipov <dmantipov@yandex.ru>
To: Barry OReilly <gundaetiapo@gmail.com>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Cc: stephen.berman@gmx.net, 15405@debbugs.gnu.org,
	Leo Liu <sdl.web@gmail.com>
Subject: bug#15405: 24.3; #[] freezes emacs
Date: Thu, 26 Sep 2013 01:50:23 +0400	[thread overview]
Message-ID: <52435A9F.9020701@yandex.ru> (raw)
In-Reply-To: <CAFM41H26-1K_Rxf4C_tVCWS9mYw=kprXJKwarV-orDw8706BZg@mail.gmail.com>

On 09/25/2013 11:09 PM, Barry OReilly wrote:

> How's this?

OK for me, except...

> @@ -3132,6 +3132,8 @@ usage: (vector &rest OBJECTS)  */)
>   void
>   make_byte_code (struct Lisp_Vector *v)
>   {
> +  /* Don't allow the global zero_vector to become a byte code object. */
> +  eassert(v->header.size!=0);

Since v->header.size is signed (ptrdiff_t), I would suggest

eassert (v->header.size > 0)

for the better catch of bogus values.

Thanks,
Dmitry







  reply	other threads:[~2013-09-25 21:50 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18  1:50 bug#15405: 24.3; #[] freezes emacs Leo Liu
2013-09-18  7:23 ` Andreas Schwab
2013-09-18 14:36 ` Barry OReilly
2013-09-18 15:07   ` Eli Zaretskii
2013-09-18 15:14     ` Barry OReilly
2013-09-18 15:27       ` Eli Zaretskii
2013-09-18 15:41         ` Stephen Berman
2013-09-18 16:26           ` Eli Zaretskii
2013-09-18 17:31             ` Barry OReilly
2013-09-18 19:26               ` Eli Zaretskii
2013-09-18 23:20                 ` Barry OReilly
2013-09-19  7:00                   ` Eli Zaretskii
2013-09-20 15:33                     ` Barry OReilly
2013-09-20 16:13                       ` Barry OReilly
2013-09-20 16:21                         ` Drew Adams
2013-09-20 19:09                       ` Stefan Monnier
2013-09-20 19:43                         ` Barry OReilly
2013-09-20 21:26                           ` Stefan Monnier
2013-09-20 21:38                             ` Barry OReilly
2013-09-21  1:28                               ` Dmitry Antipov
2013-09-21  1:39                                 ` Dmitry Antipov
2013-09-21  2:51                                 ` Stefan Monnier
2013-09-25 15:22                                   ` Barry OReilly
2013-09-25 16:12                                     ` Dmitry Antipov
2013-09-25 17:35                                       ` Stefan Monnier
2013-09-25 19:09                                         ` Barry OReilly
2013-09-25 21:50                                           ` Dmitry Antipov [this message]
2013-09-26  1:15                                           ` Stefan Monnier
2013-09-26  3:51                                             ` Barry OReilly
2013-09-25 17:10                                     ` Stefan Monnier
2013-09-18 23:41                 ` Barry OReilly
2013-09-18 17:57             ` Stephen Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52435A9F.9020701@yandex.ru \
    --to=dmantipov@yandex.ru \
    --cc=15405@debbugs.gnu.org \
    --cc=gundaetiapo@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=sdl.web@gmail.com \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.