On 9/21/13 1:35 AM, Andreas Schwab wrote: > Daniel Colascione writes: > >> On 9/21/13 12:36 AM, Andreas Schwab wrote: >>> Also, the return type should be EMACS_INT, >>> not ptrdiff_t. >> >> Well, vector_nbytes works with ptrdiff_t, and the allocation code works >> in EMACS_INT. I'm not sure the distinction actually matters in this case. > > ptrdiff_t may be smaller than EMACS_INT. We'll never overflow when we look at an already-allocated object --- but we _can_ overflow in the initial allocation calculation. I'll fix it. Thanks.