From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ryan Johnson Newsgroups: gmane.emacs.devel Subject: Re: Inlining doesn't happen on OS X: big performance problem Date: Thu, 19 Sep 2013 18:35:11 -0400 Message-ID: <523B7C1F.5050203@cs.utoronto.ca> References: <523AFDA5.4030607@dancol.org> <87y56s3h2f.fsf@igel.home> <523B656E.7020700@dancol.org> <523B6A30.3020406@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1379630158 11178 80.91.229.3 (19 Sep 2013 22:35:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Sep 2013 22:35:58 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 20 00:36:00 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMmpL-00029a-8f for ged-emacs-devel@m.gmane.org; Fri, 20 Sep 2013 00:35:59 +0200 Original-Received: from localhost ([::1]:53385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMmpK-0007ry-Pr for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2013 18:35:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMmp9-0007rg-Jv for emacs-devel@gnu.org; Thu, 19 Sep 2013 18:35:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMmow-0000Zy-V9 for emacs-devel@gnu.org; Thu, 19 Sep 2013 18:35:47 -0400 Original-Received: from bureau81.ns.utoronto.ca ([128.100.132.181]:49020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMmow-0000Zt-KJ for emacs-devel@gnu.org; Thu, 19 Sep 2013 18:35:34 -0400 Original-Received: from [192.168.1.111] (184-175-13-218.dsl.teksavvy.com [184.175.13.218] (may be forged)) (authenticated bits=0) by bureau81.ns.utoronto.ca (8.13.8/8.13.8) with ESMTP id r8JMZWVW003710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 19 Sep 2013 18:35:33 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 In-Reply-To: <523B6A30.3020406@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 128.100.132.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163489 Archived-At: On 19/09/2013 5:18 PM, Paul Eggert wrote: > On 09/19/13 13:58, Daniel Colascione wrote: >> I don't see why we've been going through the tree and replacing >> instances of "static inline" with "static" > See bug#12541; removing the "inline" helped performance slightly there. > > More generally, these days "inline" is mostly a noise word for static > functions, just as "register" is a noise word for locals. Modern > compilers inline static functions pretty well without "inline", just > as they allocate registers pretty well without "register", and it > saves maintenance hassle if developers don't have to waste their > time reading the "inline" noise and worrying about whether the > "inline" should be there. Instead, we get reports of emacs taking 3x longer to do something after "inline noise" is removed, leading some to wonder whether "inline" should be there after all... (doesn't mean you want force the compiler to inline everything, but going to either extreme is going to hurt performance) Ryan