all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ryan Johnson <ryan.johnson@cs.utoronto.ca>
To: emacs-devel@gnu.org
Subject: Re: Inlining doesn't happen on OS X: big performance problem
Date: Thu, 19 Sep 2013 18:35:11 -0400	[thread overview]
Message-ID: <523B7C1F.5050203@cs.utoronto.ca> (raw)
In-Reply-To: <523B6A30.3020406@cs.ucla.edu>

On 19/09/2013 5:18 PM, Paul Eggert wrote:
> On 09/19/13 13:58, Daniel Colascione wrote:
>> I don't see why we've been going through the tree and replacing
>> instances of "static inline" with "static"
> See bug#12541; removing the "inline" helped performance slightly there.
>
> More generally, these days "inline" is mostly a noise word for static
> functions, just as "register" is a noise word for locals.  Modern
> compilers inline static functions pretty well without "inline", just
> as they allocate registers pretty well without "register", and it
> saves maintenance hassle if developers don't have to waste their
> time reading the "inline" noise and worrying about whether the
> "inline" should be there.
Instead, we get reports of emacs taking 3x longer to do something after 
"inline noise" is removed, leading some to wonder whether "inline" 
should be there after all...

(doesn't mean you want force the compiler to inline everything, but 
going to either extreme is going to hurt performance)

Ryan




  reply	other threads:[~2013-09-19 22:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 13:35 Inlining doesn't happen on OS X: big performance problem Daniel Colascione
2013-09-19 13:44 ` Ryan Johnson
2013-09-19 15:06   ` Paul Eggert
2013-09-19 21:41     ` Paul Eggert
2013-09-20  1:47       ` Daniel Colascione
2013-09-20  4:24         ` Paul Eggert
2013-09-19 16:35 ` Andreas Schwab
2013-09-19 20:58   ` Daniel Colascione
2013-09-19 21:04     ` Andreas Schwab
2013-09-19 21:11       ` Daniel Colascione
2013-09-19 21:15         ` Andreas Schwab
2013-09-19 21:19         ` Óscar Fuentes
2013-09-19 21:18     ` Paul Eggert
2013-09-19 22:35       ` Ryan Johnson [this message]
2013-09-19 22:57         ` Paul Eggert
2013-09-20  2:35           ` Ryan Johnson
2013-09-20  6:14       ` Jan Djärv
2013-09-20  8:15         ` Dmitry Antipov
2013-09-20 14:17           ` Stefan Monnier
2013-09-20 15:37             ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523B7C1F.5050203@cs.utoronto.ca \
    --to=ryan.johnson@cs.utoronto.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.