From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Inlining doesn't happen on OS X: big performance problem Date: Thu, 19 Sep 2013 14:18:40 -0700 Organization: UCLA Computer Science Department Message-ID: <523B6A30.3020406@cs.ucla.edu> References: <523AFDA5.4030607@dancol.org> <87y56s3h2f.fsf@igel.home> <523B656E.7020700@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1379625540 26614 80.91.229.3 (19 Sep 2013 21:19:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Sep 2013 21:19:00 +0000 (UTC) Cc: Emacs development discussions To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 19 23:19:00 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMlcp-0001Dn-05 for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2013 23:18:59 +0200 Original-Received: from localhost ([::1]:53118 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMlco-0000x3-Ij for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2013 17:18:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMlcf-0000wt-4M for emacs-devel@gnu.org; Thu, 19 Sep 2013 17:18:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMlcX-0002p8-Q1 for emacs-devel@gnu.org; Thu, 19 Sep 2013 17:18:49 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:43310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMlcX-0002oq-IE for emacs-devel@gnu.org; Thu, 19 Sep 2013 17:18:41 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id AD86439E80F8; Thu, 19 Sep 2013 14:18:40 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5MqteFTjNH0o; Thu, 19 Sep 2013 14:18:40 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 594FD39E8008; Thu, 19 Sep 2013 14:18:40 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 In-Reply-To: <523B656E.7020700@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163485 Archived-At: On 09/19/13 13:58, Daniel Colascione wrote: > I don't see why we've been going through the tree and replacing > instances of "static inline" with "static" See bug#12541; removing the "inline" helped performance slightly there. More generally, these days "inline" is mostly a noise word for static functions, just as "register" is a noise word for locals. Modern compilers inline static functions pretty well without "inline", just as they allocate registers pretty well without "register", and it saves maintenance hassle if developers don't have to waste their time reading the "inline" noise and worrying about whether the "inline" should be there. It may be for some cases on some platforms that it's still helpful to use the "inline" keyword on a static function, i.e., the performance benefit outweighs the maintenance hassle. These can be handled on a case by case basis. Adding "inline" might hurt performance on one platform even if it helps on another, so some care should be taken.