From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: Inlining doesn't happen on OS X: big performance problem Date: Thu, 19 Sep 2013 13:58:22 -0700 Message-ID: <523B656E.7020700@dancol.org> References: <523AFDA5.4030607@dancol.org> <87y56s3h2f.fsf@igel.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rQNJujTCmO0sbI0CFhigC4U9freVK7o2V" X-Trace: ger.gmane.org 1379624386 13544 80.91.229.3 (19 Sep 2013 20:59:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Sep 2013 20:59:46 +0000 (UTC) Cc: Paul Eggert , Emacs development discussions To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 19 22:59:49 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMlKH-00022t-DQ for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2013 22:59:49 +0200 Original-Received: from localhost ([::1]:53055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMlKG-0004eG-W2 for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2013 16:59:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMlK8-0004eB-KZ for emacs-devel@gnu.org; Thu, 19 Sep 2013 16:59:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMlK2-0005ZK-GL for emacs-devel@gnu.org; Thu, 19 Sep 2013 16:59:40 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:40063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMlK2-0005ZE-AT for emacs-devel@gnu.org; Thu, 19 Sep 2013 16:59:34 -0400 Original-Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[192.168.1.2]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1VMlJy-0007zW-CJ; Thu, 19 Sep 2013 13:59:30 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 In-Reply-To: <87y56s3h2f.fsf@igel.home> X-Enigmail-Version: 1.5.2 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163480 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rQNJujTCmO0sbI0CFhigC4U9freVK7o2V Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 9/19/13 9:35 AM, Andreas Schwab wrote: > Daniel Colascione writes: >=20 >> Can we please remove these "!defined __APPLE__" tests and start inlini= ng >> functions again in OS X? >=20 > Why doesn't the compiler inline static functions by itself? Why should it? Also, I don't see why we've been going through the tree and replacing instances of "static inline" with "static": sure, it's possible for the compiler to inline non-"inline" functions, and even functions marked "inline" might not get inlined, but "static inline" is a good hint and makes inlining much more likely. Why should we remove this hint? --rQNJujTCmO0sbI0CFhigC4U9freVK7o2V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (Darwin) iQIcBAEBAgAGBQJSO2VzAAoJEMAaIROpHW7I1ZQP/01Brw8QIFDdUN4fo2OXhy09 x0y//KcngvhTjXN1gFXV1XDCz80brfsK8/CRobFiRkjhMhDl62+DLa+lvR9QsE2M LApY3YeEOfplXM0nfG5dZfa6hPp+/BxxZh/KZZ9Ep8I8QpNUTvO2X3q8iU3gHL7K 7KPAt1In61ljMSEkDd9mdW2kxaymHutN0bUNsaKxPl9ah040GyEg+F+wEpWsdyKF n06qThWWXEvIeLUAftoaK+H8JQLflRUUfWDwhxRFtoDPyM9Vu3BagXKIQxxCmLER fT6A7ybPXtxI6U1VHTokeZfAckZybgrCRMN2/8ObSD+GvIFgLYDDBApWkkWwCgv/ kRnXP0C7FWThJ3VKHERjybst6FE7oLzae3miBm0qoCgqeLazlpVswQyVjnUnKpKQ Fgy0DQTn/qBOyhKaqHq7cEteo7fCG1HddecPulWXpPG03zWOMuJgWavyBhsYL/Eq sNDnKahkE3GRM1jOGrdAc5G3hRgMzasN7Yndby08EIAWW+UJzXxi7C95WzJbdl3v nLKyaWxZ4X1JKwPGZpcwCjb3f6Lpstb4H13ytY4ncvatKLI6cIfU65vCfFaUEbK8 cTiYjKiFK+HkNarkAkfsvcfvJlctfL87HYmH5Q9tjs+ZahDbI3Jwj/jfPAavtMua oAfVV7UB1r7GlnyRyumR =dXpj -----END PGP SIGNATURE----- --rQNJujTCmO0sbI0CFhigC4U9freVK7o2V--