From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 15365@debbugs.gnu.org
Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend
Date: Sun, 15 Sep 2013 17:53:04 +0300 [thread overview]
Message-ID: <5235C9D0.4020105@yandex.ru> (raw)
In-Reply-To: <83eh8qfvx4.fsf@gnu.org>
On 15.09.2013 09:20, Eli Zaretskii wrote:
> Do the situations that triggered the bug involve font changes?
Not to my knowledge, no.
> In any case, that revision was about making redisplay optimizations
> more aggressive, so it is small wonder that try_window_id, which is
> part of those optimizations, is now called in situations where
> previously it wasn't. IOW, it is quite possible that there's nothing
> wrong with try_window_id being invoked in these situations.
I see.
>> (TIL that 'git bisect', unlike its Bazaar counterpart, supports
>> filtering commits by files they touched. xdisp.c, in this example).
>
> The display engine is not limited to xdisp.c; dispnew.c and
> dispextern.h are important parts of it, and sometimes window.c and the
> display-specific back-ends (xterm.c and xfns.c for X and similarly for
> w32 and NS) are also involved.
I figured that most changes to the display engine would still touch
xdisp.c, though maybe it was just a lucky guess.
>> None of GitHub repositories are publicly writable, so there's zero
>> danger of that.
>
> Thanks, I didn't know that. (Of course, I never had to use GitHub,
> either.)
I think it's the same with most of the project hostings. Such as
Savannah, for example.
> I know about "git push" vs "git commit". What I didn't know is what
> exactly do the Emacs commands you used do, in git terms, and how does
> that relate to commit and push and the myriad of their options. The
> only thing that was clear to me was that a commit is required, because
> that's what "C-x v v" does in a modified buffer. I know nothing about
> "C-c C-e" in that context.
`C-x v v` won't perform the commit until you press `C-c C-c`.
`vc-git-log-edit-toggle-amend` works in a Log-Edit buffer. It just
toggles the value of the "Amend" header and inserts the last commit's
message, so that the user can edit it before committing.
> And even if I knew that "push" is not involved, committing to a
> repository that tracks upstream development (which is all I do with
> git) would need some way to subsequently un-commit that, something I
> don't know how to do with git. I didn't want to screw up my work on
> GNU Make and Gawk, I'm sure you will understand.
Sure. But just in case you're eventually going to make time to study
Git, 'git reset' is the command you're looking for.
And speaking of experimenting, you can just create a new local
repository, not tied to any remotes, with 'git init'.
next prev parent reply other threads:[~2013-09-15 14:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 11:55 bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Dmitry Gutov
2013-09-13 13:18 ` Eli Zaretskii
2013-09-14 1:12 ` Dmitry Gutov
2013-09-14 8:02 ` Eli Zaretskii
2013-09-14 8:34 ` martin rudalics
2013-09-14 8:59 ` Eli Zaretskii
2013-09-14 9:47 ` martin rudalics
2013-09-14 10:16 ` Eli Zaretskii
2013-09-14 13:08 ` Dmitry Gutov
2013-09-14 13:45 ` Eli Zaretskii
2013-09-15 3:01 ` Dmitry Gutov
2013-09-15 6:20 ` Eli Zaretskii
2013-09-15 14:53 ` Dmitry Gutov [this message]
2013-09-14 13:05 ` Dmitry Gutov
2013-09-14 13:29 ` Eli Zaretskii
2013-09-19 8:23 ` Eli Zaretskii
2013-09-22 5:00 ` Dmitry Gutov
2013-09-22 7:14 ` Eli Zaretskii
2013-09-14 14:37 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5235C9D0.4020105@yandex.ru \
--to=dgutov@yandex.ru \
--cc=15365@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.