From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#15365: 24.3.50; Segfault when calling vc-git-log-edit-toggle-amend Date: Sat, 14 Sep 2013 16:08:17 +0300 Message-ID: <52345FC1.3020305@yandex.ru> References: <8761u5rl5c.fsf@yandex.ru> <83zjrghnca.fsf@gnu.org> <5233B818.5050705@yandex.ru> <838uyzhlv5.fsf@gnu.org> <52341F9A.6030102@gmx.at> <837gejhj7v.fsf@gnu.org> <523430BB.2070902@gmx.at> <83y56zg13n.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1379164162 27580 80.91.229.3 (14 Sep 2013 13:09:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Sep 2013 13:09:22 +0000 (UTC) Cc: 15365@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 14 15:09:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VKpbF-0004Ex-FX for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2013 15:09:21 +0200 Original-Received: from localhost ([::1]:53323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKpbE-0000Hg-TX for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Sep 2013 09:09:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKpb5-0000HS-1v for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 09:09:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKpax-0004Xy-CL for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 09:09:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKpax-0004Xr-8c for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 09:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VKpaw-0004dD-7w for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2013 09:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2013 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15365-submit@debbugs.gnu.org id=B15365.137916411217756 (code B ref 15365); Sat, 14 Sep 2013 13:09:02 +0000 Original-Received: (at 15365) by debbugs.gnu.org; 14 Sep 2013 13:08:32 +0000 Original-Received: from localhost ([127.0.0.1]:36067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKpaO-0004cE-8w for submit@debbugs.gnu.org; Sat, 14 Sep 2013 09:08:29 -0400 Original-Received: from mail-wg0-f47.google.com ([74.125.82.47]:63791) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKpaL-0004bz-8K for 15365@debbugs.gnu.org; Sat, 14 Sep 2013 09:08:25 -0400 Original-Received: by mail-wg0-f47.google.com with SMTP id f12so2147436wgh.14 for <15365@debbugs.gnu.org>; Sat, 14 Sep 2013 06:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=wTaG+v7Tvvxu1QuoCRqM25TsgKxYKClu5GH12gGOqtc=; b=R9femc9GcWX8XqNJK7PKhNxHYVPaOZhPaaz3x66fb9QOHdOreJh2YMIpVYFScqYxTW 1JyQRyyxkzkhl8/6i8WICK55z0bbCuvqLhO42MqzRK92lzKH1ALcAp2mi2pcKxAtaJLG 0ezWWt0rQGA/0FnHiINqQPWOBOovQdvKw/W16t91aQiHPRmJ+mHzcXYoaU3dmYVuK4vS xqHlZQJuEssGgtS3SequVoZpXI/MenNJizSHOIaV0IVQmlfVFsZtW86RwDA7XW+HXaNI T8LOV430PkXmXp4v2dmSLK+rtB8HF+lfd1jPa5+pf5iJ1/TxJ/wuKJvHTGDPnBXctGAW msnQ== X-Received: by 10.194.71.72 with SMTP id s8mr72021wju.52.1379164099534; Sat, 14 Sep 2013 06:08:19 -0700 (PDT) Original-Received: from [192.168.10.2] (62-118-214.netrun.cytanet.com.cy. [62.228.118.214]) by mx.google.com with ESMTPSA id i8sm10000387wiy.6.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Sep 2013 06:08:18 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 In-Reply-To: <83y56zg13n.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78397 Archived-At: On 14.09.2013 13:16, Eli Zaretskii wrote: > My analysis concluded that it wasn't supposed to abort, just not call > set_cursor_from_row in that case. The call to abort was added long > ago, when row_containing_pos got a minor modification, and the person > who made the change thought that perhaps that change will cause > damage. I think we can remove that call to abort now. And if that > causes any regressions, there's a more drastic way of calling GIVE_UP > in that case. Since that code is old, I wonder what could have changed lately. I've been using `vc-git-log-edit-toggle-amend' without crashes for nearly a year now, since it's been added.