From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: Caching where-is-internal (was: (icomplete-vertical-mode): Add support for affixations and, annotations) Date: Mon, 24 May 2021 18:31:10 +0200 Message-ID: <5213fac0-fcc9-a6aa-0a16-a124d9ec92bc@daniel-mendler.de> References: <87zgwlb4xc.fsf@gmail.com> <87eedxrqz4.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9300"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Juri Linkov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 18:34:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llDXF-00027M-8U for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 18:34:33 +0200 Original-Received: from localhost ([::1]:43790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llDXE-00044a-8x for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 12:34:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llDU5-0001ZH-P4 for emacs-devel@gnu.org; Mon, 24 May 2021 12:31:19 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:37661 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llDU2-00010G-Sd for emacs-devel@gnu.org; Mon, 24 May 2021 12:31:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LM52TfbLeVHRMTeWzrEtrVPN4eReAlyGIp4qXt+rFbE=; b=QQIq6dj2KO/0n6HTgdfFXZgbK5 0zERVIOqDUONfUPI3tz5d9KeJCA1VzBdXurTy6fUzTFvzh43hkppt2R60l2ChyYy3/8YQTzv92ZMR 9GnGprVFAxX/sz1MgDlAwZfDo+FYTLZh7Zy5GjF3GKK4tof+xULATydMfa0kojeLl6tg=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269776 Archived-At: On 5/24/21 6:22 PM, Stefan Monnier wrote: > `where-is-internal` is supposed to do its own caching already (I added > that around the time of Emacs-21 because it was making construction of > the menubar too slow). So if you see problems on that side, please > report them. I think the problem was that `where-is-internal` can generate a lot of garbage memory. In Marginalia we have this code: ~~~ (defun marginalia-annotate-binding (cand) "Annotate command CAND with keybinding." ;; Precomputing the keybinding of every command is faster than ;; looking it up every time using `where-is-internal'. ;; `where-is-internal' generates a lot of garbage, leading to ;; garbage collecting pauses when interacting with the minibuffer. ;; See https://github.com/minad/marginalia/issues/16. (unless marginalia--annotate-binding-hash (setq marginalia--annotate-binding-hash (make-hash-table :size 1025)) (mapatoms (lambda (sym) (when-let (key (and (commandp sym) (where-is-internal sym nil t))) (puthash sym key marginalia--annotate-binding-hash))))) (when-let* ((sym (intern-soft cand)) (binding (gethash sym marginalia--annotate-binding-hash))) (propertize (format " (%s)" (key-description binding)) 'face 'marginalia-key))) ~~~ But I cannot tell you much about the exact reasons. It just turned out that calling `where-is-internal` once on all symbols was faster than calling it occasionally. In Vertico/Selectrum etc, the `marginalia-annotate-binding` function is called for each candidate and the difference was noticeable when scrolling through the candidate list. The funny thing here is that the initial (costly?) computation of the `marginalia--annotate-binding-hash` does not lead to a noticeable slowdown. Daniel