From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: trunk r113953: * image.c: Shrink memory needed for animation cache. Date: Mon, 19 Aug 2013 17:53:55 -0700 Organization: UCLA Computer Science Department Message-ID: <5212BE23.9000604@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1376960060 22978 80.91.229.3 (20 Aug 2013 00:54:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Aug 2013 00:54:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 20 02:54:18 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VBaD9-0006ja-AW for ged-emacs-devel@m.gmane.org; Tue, 20 Aug 2013 02:54:15 +0200 Original-Received: from localhost ([::1]:45417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBaD8-0002j5-Vl for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 20:54:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBaD0-0002it-3R for emacs-devel@gnu.org; Mon, 19 Aug 2013 20:54:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBaCs-0003Cy-42 for emacs-devel@gnu.org; Mon, 19 Aug 2013 20:54:06 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:57440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBaCr-0003CS-Ud for emacs-devel@gnu.org; Mon, 19 Aug 2013 20:53:58 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id C771AA60001; Mon, 19 Aug 2013 17:53:56 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pa4XrViSHAHD; Mon, 19 Aug 2013 17:53:56 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-71-108-49-126.lsanca.fios.verizon.net [71.108.49.126]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 5A14639E80F8; Mon, 19 Aug 2013 17:53:56 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 In-Reply-To: X-Enigmail-Version: 1.5.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162901 Archived-At: Lars Magne Ingebrigtsen wrote: > Do we really need to know this? It's a zero-terminated string (in a > larger block), so just by calling strdup, we're OK, and we don't need > any magical constants. Calling strdup would mean we'd be calling malloc twice instead of once. Insted, we can make the signature a flexible array member. This is a bit slower than what we had, but it's better than calling malloc twice and it would insulate us better if ImageMagick switches to a different digest format. I did that in trunk bzr 113954.