From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: trunk r113947: * image.c: Fix animation cache signature memory leak. Date: Mon, 19 Aug 2013 13:52:31 -0700 Organization: UCLA Computer Science Department Message-ID: <5212858F.4020308@cs.ucla.edu> References: <521244F0.3060508@cs.ucla.edu> <521246C4.3070004@cs.ucla.edu> <52124E37.2080709@cs.ucla.edu> <52127603.5030809@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1376945567 6778 80.91.229.3 (19 Aug 2013 20:52:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Aug 2013 20:52:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 19 22:52:50 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VBWRW-00067H-1F for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 22:52:50 +0200 Original-Received: from localhost ([::1]:44864 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBWRV-0007LX-8A for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 16:52:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBWRN-0007Ek-74 for emacs-devel@gnu.org; Mon, 19 Aug 2013 16:52:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBWRG-0000nP-EG for emacs-devel@gnu.org; Mon, 19 Aug 2013 16:52:41 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:47513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBWRG-0000mz-8W for emacs-devel@gnu.org; Mon, 19 Aug 2013 16:52:34 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 9C08539E80F8; Mon, 19 Aug 2013 13:52:32 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u3ydtzXYDIUm; Mon, 19 Aug 2013 13:52:32 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-71-108-49-126.lsanca.fios.verizon.net [71.108.49.126]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E8A7F39E8008; Mon, 19 Aug 2013 13:52:31 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 In-Reply-To: X-Enigmail-Version: 1.5.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162893 Archived-At: Lars Magne Ingebrigtsen wrote: > Sure. OK, installed as trunk bzr 113953. > https://i.chzbgr.com/maxW500/7733068032/hCDD37D15/ Ah, when I visit that as a file, and type RET, the image is animated but this new image.c code is bypassed, since HAVE_GIF is true on my platform. I thought I'd taken that into account in my earlier testing, by unsetting HAVE_GIF in config.h, but perhaps not. Are you configuring with the GIF, PNG, etc. libraries disabled? I ask because animated PNGs don't work on my copy, but I'm using libpng instead of ImageMagick for PNGs.