From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#15094: Fix for posix_memalign on Cygwin Date: Thu, 15 Aug 2013 12:15:49 -0400 Message-ID: <520CFEB5.1000206@cornell.edu> References: <520BAEBA.1030306@cornell.edu> <520BD64D.2000906@cornell.edu> <8361v8oyv2.fsf@gnu.org> <520BE015.5080107@cornell.edu> <831u5vpt65.fsf@gnu.org> <520CC0C8.2000805@cornell.edu> <520CD0D6.6060200@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1376583374 3822 80.91.229.3 (15 Aug 2013 16:16:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Aug 2013 16:16:14 +0000 (UTC) Cc: 15094@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 15 18:16:15 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VA0Df-0000Hi-64 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2013 18:16:15 +0200 Original-Received: from localhost ([::1]:54363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VA0De-0004kA-EM for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Aug 2013 12:16:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VA0DX-0004k1-Hp for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2013 12:16:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VA0DS-0000FZ-De for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2013 12:16:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VA0DS-0000FS-Ah for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2013 12:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VA0DR-0000F2-KJ for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2013 12:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Aug 2013 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15094 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15094-submit@debbugs.gnu.org id=B15094.1376583358917 (code B ref 15094); Thu, 15 Aug 2013 16:16:01 +0000 Original-Received: (at 15094) by debbugs.gnu.org; 15 Aug 2013 16:15:58 +0000 Original-Received: from localhost ([127.0.0.1]:60687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VA0DN-0000Ei-P6 for submit@debbugs.gnu.org; Thu, 15 Aug 2013 12:15:58 -0400 Original-Received: from limerock04.mail.cornell.edu ([128.84.12.60]:42122) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VA0DK-0000EQ-St for 15094@debbugs.gnu.org; Thu, 15 Aug 2013 12:15:55 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id r7FGFnCA019176; Thu, 15 Aug 2013 12:15:49 -0400 Original-Received: from [128.84.234.244] (dhcp244.math.cornell.edu [128.84.234.244]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r7FGFm6B000951 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 15 Aug 2013 12:15:48 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 In-Reply-To: <520CD0D6.6060200@cornell.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:77387 Archived-At: On 8/15/2013 9:00 AM, Ken Brown wrote: > On 8/15/2013 7:51 AM, Ken Brown wrote: >> On 8/14/2013 10:46 PM, Eli Zaretskii wrote: >>>> Date: Wed, 14 Aug 2013 15:52:53 -0400 >>>> From: Ken Brown >>>> CC: 15094@debbugs.gnu.org >>>> >>>> /* Cygwin allows applications to provide their own malloc. As of >>>> cygwin-1.7.24, applications that provide their own malloc are also >>>> allowed to provide their own posix_memalign (but not memalign). Calls >>>> to memalign are handled by Cygwin's memalign, which always returns >>>> ENOSYS if the application has defined its own malloc. So we have to >>>> rename memalign in order to make sure that posix_memalign calls >>>> Emacs's memalign rather than Cygwin's. */ >>> >>> How does Cygwin memalign come into play, when Emacs provides its own? >> >> As I said in the comment, Cygwin does not let applications define their >> own memalign. During linking, calls to memalign become calls to >> Cygwin's memalign. > > Hold on...I think I'm missing something obvious. I have to recheck this. Thanks for pressing me on this, Eli. I did of course miss the obvious fact that posix_memalign in gmalloc.c will use memalign as defined in the same file. I'll revert the change. I'll also use the opportunity to update some comments elsewhere in the code. Sorry for the noise. Ken