From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Date: Sun, 25 Aug 2024 09:26:12 -0700 Message-ID: <5209fe94-6999-ae56-2b6e-27f8c37c8b1d@gmail.com> References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <86h6bcubn0.fsf@gnu.org> <86r0adkqlp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------5UOCjJIxrqUu5CqClkESKgVX" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29912"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 25 18:28:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1siG6T-0007bW-5v for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Aug 2024 18:28:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1siG6E-0006hj-5K; Sun, 25 Aug 2024 12:28:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1siG69-0006h7-CQ for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2024 12:28:13 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1siG69-00008L-3B for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2024 12:28:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=qlYe3oTT3jnlyGvD5sOF0tvuznD+qXuUtQ0qm3YPHuI=; b=j80tIRTyt21mhDfRAb+gZMlbXo6blqq6Qn3EW05fT40Wm6KWynWVYHefgBe2NyMvpgrdJNJPDdDsDXR4su0WCmCktDvSBY4lRtfqLjF3bb1+SJzuzIn6xDHR1sfD0NXoa/Qi+UH/BpmJJcq7W3k/sIKbCB/Fij+yP6ktnWbwg2TMPxPm6L0LNMH2oHGcxZtBC+dTeIxVgFTsj+jUhPH6F3Dmlw4NMCshnvdY44CxmWri2sU6H65v70D23HWBdyUkS/G0ykkrLRumy7ykEDA2gzCdv+67dh6MvehQAwSQQdOb3t6p5ToR00Niyu5RPFvh3mIZ24cJaJEBYrqmf0xkRQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1siG6w-00030t-6a for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2024 12:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2024 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72721 X-GNU-PR-Package: emacs Original-Received: via spool by 72721-submit@debbugs.gnu.org id=B72721.172460329011511 (code B ref 72721); Sun, 25 Aug 2024 16:29:02 +0000 Original-Received: (at 72721) by debbugs.gnu.org; 25 Aug 2024 16:28:10 +0000 Original-Received: from localhost ([127.0.0.1]:43182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siG66-0002za-FW for submit@debbugs.gnu.org; Sun, 25 Aug 2024 12:28:10 -0400 Original-Received: from mail-pl1-f169.google.com ([209.85.214.169]:48312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1siG64-0002zJ-H2 for 72721@debbugs.gnu.org; Sun, 25 Aug 2024 12:28:09 -0400 Original-Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-201df0b2df4so27840505ad.0 for <72721@debbugs.gnu.org>; Sun, 25 Aug 2024 09:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724603172; x=1725207972; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=qlYe3oTT3jnlyGvD5sOF0tvuznD+qXuUtQ0qm3YPHuI=; b=FbJV/ovTc+XNrpmVcuCMloIC+WGCVhUfIqAd9TY8aWRK/+FXj2oS6ThVhSbSnzW1De IrcrFcaPS64YXkUS0QALbAt4+tmdqUhqx9hUMTont3J0/4g5l6LTrY4ukkV+tpokjJrv dySRPPmOHaqCPzdqjZfpojBiFHw2ECXqr3BsBb85SW0v8rLp+ayF5At1WNNCzS3Pbs9x x+pZDkcx54KPHuts0U2QtRpzGdB+RnbC19By0T8/ExoWfRFcApwVn3+t+pfTCR6VHJ7s 2iE/CKj25cvoU63l+gdvLZLuW4uPzYmR4/mMMCF5DEV//PJh+jhMH4j5xACNKtqLetDA IJHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724603172; x=1725207972; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qlYe3oTT3jnlyGvD5sOF0tvuznD+qXuUtQ0qm3YPHuI=; b=xOxsXe5Ec0kB3Urx+SQVIYvrE3kYFehx56byGgBy5KWnDrnQCSDtP65JFp9LkYjFRO uHLzfkUxpCsgk3XJrD/XcJy8xVEAmFegduulQagjCwAskEXbUAF2SJ8L0nmQcKhzxpKj Ml8XQNuKbJkIzF3DbyXq9n2lWSQZYlhgv9Y5aOBtYifVnKrNct2ThVa8RkmD3QdMC4pI HJMtUS6nEe+2XZc+5w6OOry4pE67yEAUFBUPgDp4dEwPaxZLY4/EF+exkU3ZIt6XvktN U2r2VQiZpnyaKnMIJXGkOSiAX2ib5CcbIcCloJ/d56xfk+YPUu+jTTw+q0kAyMe18l60 bglQ== X-Gm-Message-State: AOJu0Yy1F7lmnRnqvgfVgFKAVWg5gAw4+dn4d1z5T/nUDKrCNIt4iZAP B6B9PQeP/ob9ZvbKtIOFh0LyIxG8YYRMz4SOzxNsiDsONTHNPmJZVQkePw== X-Google-Smtp-Source: AGHT+IHy7iVfT6tZX+BpAF5K1JUaCqm8d2quPBk0jS/swjC4BpnaVidVrGgXer5UzwOCTR0i7j3MwA== X-Received: by 2002:a17:902:f64b:b0:1fa:4b9:d00f with SMTP id d9443c01a7336-2039e51b70fmr82846675ad.53.1724603172097; Sun, 25 Aug 2024 09:26:12 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-20385566585sm55804675ad.4.2024.08.25.09.26.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Aug 2024 09:26:11 -0700 (PDT) Content-Language: en-US In-Reply-To: <86r0adkqlp.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290746 Archived-At: This is a multi-part message in MIME format. --------------5UOCjJIxrqUu5CqClkESKgVX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/25/2024 12:29 AM, Eli Zaretskii wrote: > I made the change to use Fget_char_property and installed the > changeset on the master branch. Please note that overlays can be > window-specific, and the changes I installed are supposed to handle > that, but I didn't test that too much. Please test with > window-specific overlays and see if it works correctly; if not, I'd > appreciate a test case for looking into the failure. Thanks for merging. Everything looks correct to me. I've added a few more test cases to exercise window-specific overlays and they all work the way I'd expect. See attached. --------------5UOCjJIxrqUu5CqClkESKgVX Content-Type: text/plain; charset=UTF-8; name="test-cases.el" Content-Disposition: attachment; filename="test-cases.el" Content-Transfer-Encoding: base64 KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IDY3OCAgICAg OTAKICAoc3dpdGNoLXRvLWJ1ZmZlciAic2ltcGxlIikKICAoZXJhc2UtYnVmZmVyKQogIChp bnNlcnQgIjEyMzQ1XG42Nzg5MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVy dHkKICAgNyAxMCAnZGlzcGxheSAnKChtaW4td2lkdGggKDgpKSkpKQoKCihwcm9nbgogIDs7 IFNob3VsZCBsb29rIGxpa2U6CiAgOzsgMTIzNDUKICA7OyA2NyAgODkgIDAKICAoc3dpdGNo LXRvLWJ1ZmZlciAiY29uc2VjdXRpdmUiKQogIChlcmFzZS1idWZmZXIpCiAgKGluc2VydCAi MTIzNDVcbjY3ODkwIikKICAocmVkaXNwbGF5KQogIChwdXQtdGV4dC1wcm9wZXJ0eQogICA3 IDkgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKQogIChwdXQtdGV4dC1wcm9wZXJ0eQog ICA5IDExICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoNCkpKSkpCgoKKHByb2duCiAgOzsgU2hv dWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NQogIDs7IGhpICA4OTAKICAoc3dpdGNoLXRvLWJ1 ZmZlciAibmVzdGVkIikKICAoZXJhc2UtYnVmZmVyKQogIChpbnNlcnQgIjEyMzQ1XG42Nzg5 MCIpCiAgKHJlZGlzcGxheSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyA5ICdkaXNwbGF5 CiAgIChwcm9wZXJ0aXplICJoaSIgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg0KSkpKSkpCgoK KHByb2duCiAgOzsgU2hvdWxkIGxvb2sgbGlrZToKICA7OyAxMjM0NSAgICAgICAgIHwKICA7 OyA2NzggICAgIDkwICAgIHxYCiAgKHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXkiKQogIChl cmFzZS1idWZmZXIpCiAgKGluc2VydCAiMTIzNDVcbjY3ODkwIikKICAoc2V0LXdpbmRvdy1t YXJnaW5zIChzZWxlY3RlZC13aW5kb3cpIDAgMSkKICAocmVkaXNwbGF5KQogIChzZXRxIG8g KG1ha2Utb3ZlcmxheSA4IDkpKQogIChvdmVybGF5LXB1dCBvICdiZWZvcmUtc3RyaW5nCiAg ICAgICAgICAgICAgIChwcm9wZXJ0aXplICJvIiAnZGlzcGxheSAnKChtYXJnaW4gcmlnaHQt bWFyZ2luKSAiWCIpKSkKICAocHV0LXRleHQtcHJvcGVydHkKICAgNyAxMCAnZGlzcGxheSAn KChtaW4td2lkdGggKDgpKSkpKQoKCihwcm9nbgogIDs7IFNob3VsZCBsb29rIGxpa2U6CiAg OzsgMTIzNDUKICA7OyA2NzggICAgIDkwCiAgKHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXkt bWluLXdpZHRoIikKICAoZXJhc2UtYnVmZmVyKQogIChpbnNlcnQgIjEyMzQ1XG42Nzg5MCIp CiAgKHNldC13aW5kb3ctbWFyZ2lucyAoc2VsZWN0ZWQtd2luZG93KSAwIDEpCiAgKHJlZGlz cGxheSkKICAoc2V0cSBvIChtYWtlLW92ZXJsYXkgNyAxMCkpCiAgKG92ZXJsYXktcHV0IG8g J2Rpc3BsYXkgJygobWluLXdpZHRoICg4KSkpKSkKCgoocHJvZ24KICA7OyBTaG91bGQgbG9v ayBsaWtlOgogIDs7IDEyMzQ1ICAgICAgICAgfAogIDs7IDY3OCAgICAgOTAgICAgfFgKICAo c3dpdGNoLXRvLWJ1ZmZlciAib3ZlcmxheS1tdWx0aSIpCiAgKGVyYXNlLWJ1ZmZlcikKICAo aW5zZXJ0ICIxMjM0NVxuNjc4OTAiKQogIChzZXQtd2luZG93LW1hcmdpbnMgKHNlbGVjdGVk LXdpbmRvdykgMCAxKQogIChyZWRpc3BsYXkpCiAgKHNldHEgbzEgKG1ha2Utb3ZlcmxheSA3 IDEwKSkKICAob3ZlcmxheS1wdXQgbzEgJ2Rpc3BsYXkgJygobWluLXdpZHRoICg4KSkpKQog IChzZXRxIG8yIChtYWtlLW92ZXJsYXkgOCA5KSkKICAob3ZlcmxheS1wdXQgbzIgJ2JlZm9y ZS1zdHJpbmcKICAgICAgICAgICAgICAgKHByb3BlcnRpemUgIm8iICdkaXNwbGF5ICcoKG1h cmdpbiByaWdodC1tYXJnaW4pICJYIikpKSkKCgoocHJvZ24KICA7OyBTaG91bGQgbG9vayBs aWtlOgogIDs7IDEyMzQ1CiAgOzsgNjc4ICAgICA5MAogIDs7ID09PT09PT09PT09PT09PT09 PT09CiAgOzsgMTIzNDUKICA7OyA2Nzg5MAogIChzd2l0Y2gtdG8tYnVmZmVyICJvdmVybGF5 LXdpbmRvdyIpCiAgKHNwbGl0LXdpbmRvdy1iZWxvdykKICAoZXJhc2UtYnVmZmVyKQogIChp bnNlcnQgIjEyMzQ1XG42Nzg5MCIpCiAgKHJlZGlzcGxheSkKICAoc2V0cSBvIChtYWtlLW92 ZXJsYXkgNyAxMCkpCiAgKG92ZXJsYXktcHV0IG8gJ2Rpc3BsYXkgJygobWluLXdpZHRoICg4 KSkpKQogIChvdmVybGF5LXB1dCBvICd3aW5kb3cgKHNlbGVjdGVkLXdpbmRvdykpKQoKCihw cm9nbgogIDs7IFNob3VsZCBsb29rIGxpa2U6CiAgOzsgMTIzNDUKICA7OyA2NzggICAgIDkw CiAgOzsgPT09PT09PT09PT09PT09PT09PT0KICA7OyAxMjM0NQogIDs7IDY3ICAgODkwCiAg KHN3aXRjaC10by1idWZmZXIgIm92ZXJsYXktd2luZG93LW11bHRpIikKICAoc3BsaXQtd2lu ZG93LWJlbG93KQogIChlcmFzZS1idWZmZXIpCiAgKGluc2VydCAiMTIzNDVcbjY3ODkwIikK ICAocmVkaXNwbGF5KQogIChzZXRxIG8xIChtYWtlLW92ZXJsYXkgNyAxMCkpCiAgKG92ZXJs YXktcHV0IG8xICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoOCkpKSkKICAob3ZlcmxheS1wdXQg bzEgJ3dpbmRvdyAoc2VsZWN0ZWQtd2luZG93KSkKICAoc2V0cSBvMiAobWFrZS1vdmVybGF5 IDcgOSkpCiAgKG92ZXJsYXktcHV0IG8yICdkaXNwbGF5ICcoKG1pbi13aWR0aCAoNSkpKSkK ICAob3ZlcmxheS1wdXQgbzIgJ3dpbmRvdyAoY2FyIChsYXN0ICh3aW5kb3ctbGlzdCkpKSkp Cg== --------------5UOCjJIxrqUu5CqClkESKgVX--