bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers

[Jim Porter <jporterbugs@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

On 8/25/2024 12:29 AM, Eli Zaretskii wrote:
> I made the change to use Fget_char_property and installed the
> changeset on the master branch.  Please note that overlays can be
> window-specific, and the changes I installed are supposed to handle
> that, but I didn't test that too much.  Please test with
> window-specific overlays and see if it works correctly; if not, I'd
> appreciate a test case for looking into the failure.

Thanks for merging. Everything looks correct to me. I've added a few 
more test cases to exercise window-specific overlays and they all work 
the way I'd expect. See attached.

[-- Attachment #2: test-cases.el --]
[-- Type: text/plain, Size: 2647 bytes --]

(progn
  ;; Should look like:
  ;; 12345
  ;; 678     90
  (switch-to-buffer "simple")
  (erase-buffer)
  (insert "12345\n67890")
  (redisplay)
  (put-text-property
   7 10 'display '((min-width (8)))))


(progn
  ;; Should look like:
  ;; 12345
  ;; 67  89  0
  (switch-to-buffer "consecutive")
  (erase-buffer)
  (insert "12345\n67890")
  (redisplay)
  (put-text-property
   7 9 'display '((min-width (4))))
  (put-text-property
   9 11 'display '((min-width (4)))))


(progn
  ;; Should look like:
  ;; 12345
  ;; hi  890
  (switch-to-buffer "nested")
  (erase-buffer)
  (insert "12345\n67890")
  (redisplay)
  (put-text-property
   7 9 'display
   (propertize "hi" 'display '((min-width (4))))))


(progn
  ;; Should look like:
  ;; 12345         |
  ;; 678     90    |X
  (switch-to-buffer "overlay")
  (erase-buffer)
  (insert "12345\n67890")
  (set-window-margins (selected-window) 0 1)
  (redisplay)
  (setq o (make-overlay 8 9))
  (overlay-put o 'before-string
               (propertize "o" 'display '((margin right-margin) "X")))
  (put-text-property
   7 10 'display '((min-width (8)))))


(progn
  ;; Should look like:
  ;; 12345
  ;; 678     90
  (switch-to-buffer "overlay-min-width")
  (erase-buffer)
  (insert "12345\n67890")
  (set-window-margins (selected-window) 0 1)
  (redisplay)
  (setq o (make-overlay 7 10))
  (overlay-put o 'display '((min-width (8)))))


(progn
  ;; Should look like:
  ;; 12345         |
  ;; 678     90    |X
  (switch-to-buffer "overlay-multi")
  (erase-buffer)
  (insert "12345\n67890")
  (set-window-margins (selected-window) 0 1)
  (redisplay)
  (setq o1 (make-overlay 7 10))
  (overlay-put o1 'display '((min-width (8))))
  (setq o2 (make-overlay 8 9))
  (overlay-put o2 'before-string
               (propertize "o" 'display '((margin right-margin) "X"))))


(progn
  ;; Should look like:
  ;; 12345
  ;; 678     90
  ;; ====================
  ;; 12345
  ;; 67890
  (switch-to-buffer "overlay-window")
  (split-window-below)
  (erase-buffer)
  (insert "12345\n67890")
  (redisplay)
  (setq o (make-overlay 7 10))
  (overlay-put o 'display '((min-width (8))))
  (overlay-put o 'window (selected-window)))


(progn
  ;; Should look like:
  ;; 12345
  ;; 678     90
  ;; ====================
  ;; 12345
  ;; 67   890
  (switch-to-buffer "overlay-window-multi")
  (split-window-below)
  (erase-buffer)
  (insert "12345\n67890")
  (redisplay)
  (setq o1 (make-overlay 7 10))
  (overlay-put o1 'display '((min-width (8))))
  (overlay-put o1 'window (selected-window))
  (setq o2 (make-overlay 7 9))
  (overlay-put o2 'display '((min-width (5))))
  (overlay-put o2 'window (car (last (window-list)))))