all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Key binding to print VC root log from VC dir
@ 2013-07-24 21:41 Matthias Meulien
  2013-07-25 16:53 ` Glenn Morris
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Matthias Meulien @ 2013-07-24 21:41 UTC (permalink / raw)
  To: bug-gnu-emacs; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Severity: wishlist Tags: patch  From a buffer visiting a file 
under version control one has the following two key bindings to 
display logs:

          C-x v l runs the command vc-print-log

          C-x v L runs the command vc-print-root-log

From a buffer in `vc-dir-mode' one has the key binding:

          l runs the command vc-print-log

But there is no `vc-print-root-log' key binding...


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Key binding to print VC root log from VC dir --]
[-- Type: text/x-diff, Size: 886 bytes --]

From 58b23b29b45e2d3f17ed76e8ff010501d966d2c0 Mon Sep 17 00:00:00 2001
From: Matthias Meulien <orontee@gmail.com>
Date: Wed, 24 Jul 2013 23:39:51 +0200
Subject: [PATCH] lisp/vc/vc-dir.el (vc-dir-mode-map): Keybinding for
 vc-print-root-log

---
 lisp/vc/vc-dir.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index 80f7849..325e66e 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -240,6 +240,7 @@ See `run-hooks'."
     (define-key map "i" 'vc-register)	   ;; C-x v i
     (define-key map "+" 'vc-update)	   ;; C-x v +
     (define-key map "l" 'vc-print-log)	   ;; C-x v l
+    (define-key map "L" 'vc-print-root-log) ;; C-x v L
     ;; More confusing than helpful, probably
     ;;(define-key map "R" 'vc-revert) ;; u is taken by vc-dir-unmark.
     ;;(define-key map "A" 'vc-annotate) ;; g is taken by revert-buffer
-- 
1.8.3.3


[-- Attachment #3: Type: text/plain, Size: 34 bytes --]


Thanks for reading,
-- 
Matthias

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: Key binding to print VC root log from VC dir
  2013-07-24 21:41 Key binding to print VC root log from VC dir Matthias Meulien
@ 2013-07-25 16:53 ` Glenn Morris
  2013-07-26 10:53   ` Matthias Meulien
  2013-07-26  7:18 ` bug#14948: " Dmitry Gutov
  2013-07-27  0:11 ` Xue Fuqiao
  2 siblings, 1 reply; 14+ messages in thread
From: Glenn Morris @ 2013-07-25 16:53 UTC (permalink / raw)
  To: Matthias Meulien; +Cc: emacs-devel

Matthias Meulien wrote:

> Severity: wishlist Tags: patch  From a buffer visiting a file under

Thanks for the patches. Couple of FYIs:
Since the above items were not on separate lines, they had no effect.
Also, there is no need to send things to both emacs-devel and
bug-gnu-emacs.



^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14948: Key binding to print VC root log from VC dir
  2013-07-24 21:41 Key binding to print VC root log from VC dir Matthias Meulien
  2013-07-25 16:53 ` Glenn Morris
@ 2013-07-26  7:18 ` Dmitry Gutov
  2013-07-26  7:53   ` Stefan Monnier
  2013-07-26  7:53   ` Stefan Monnier
  2013-07-27  0:11 ` Xue Fuqiao
  2 siblings, 2 replies; 14+ messages in thread
From: Dmitry Gutov @ 2013-07-26  7:18 UTC (permalink / raw)
  To: Matthias Meulien; +Cc: emacs-devel, 14948

Matthias Meulien <orontee@gmail.com> writes:

> Severity: wishlist Tags: patch  From a buffer visiting a file under
> version control one has the following two key bindings to display
> logs:
>
>          C-x v l runs the command vc-print-log
>
>          C-x v L runs the command vc-print-root-log
>
> From a buffer in `vc-dir-mode' one has the key binding:
>
>          l runs the command vc-print-log
>
> But there is no `vc-print-root-log' key binding...

There is. It's a global one. `C-x v L' works for me in vc-dir-mode
buffers even without this patch.

What's the problem you're trying to solve?





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14948: Key binding to print VC root log from VC dir
  2013-07-26  7:18 ` bug#14948: " Dmitry Gutov
@ 2013-07-26  7:53   ` Stefan Monnier
  2013-07-26  7:53   ` Stefan Monnier
  1 sibling, 0 replies; 14+ messages in thread
From: Stefan Monnier @ 2013-07-26  7:53 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: emacs-devel, Matthias Meulien, 14948

>> C-x v l runs the command vc-print-log
>> C-x v L runs the command vc-print-root-log
>> 
>> From a buffer in `vc-dir-mode' one has the key binding:
>> 
>> l runs the command vc-print-log
>> 
>> But there is no `vc-print-root-log' key binding...

> There is. It's a global one. `C-x v L' works for me in vc-dir-mode
> buffers even without this patch.

But since `C-x v l' is duplicated as `l', it makes a lot of sense to
duplicate `C-x v L' as `L' as his patch suggests.

Could someone install his patch, please?


        Stefan





^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: bug#14948: Key binding to print VC root log from VC dir
  2013-07-26  7:18 ` bug#14948: " Dmitry Gutov
  2013-07-26  7:53   ` Stefan Monnier
@ 2013-07-26  7:53   ` Stefan Monnier
  2013-07-26  9:51     ` Juanma Barranquero
                       ` (3 more replies)
  1 sibling, 4 replies; 14+ messages in thread
From: Stefan Monnier @ 2013-07-26  7:53 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: 14948, Matthias Meulien, emacs-devel

>> C-x v l runs the command vc-print-log
>> C-x v L runs the command vc-print-root-log
>> 
>> From a buffer in `vc-dir-mode' one has the key binding:
>> 
>> l runs the command vc-print-log
>> 
>> But there is no `vc-print-root-log' key binding...

> There is. It's a global one. `C-x v L' works for me in vc-dir-mode
> buffers even without this patch.

But since `C-x v l' is duplicated as `l', it makes a lot of sense to
duplicate `C-x v L' as `L' as his patch suggests.

Could someone install his patch, please?


        Stefan



^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14948: Key binding to print VC root log from VC dir
  2013-07-26  7:53   ` Stefan Monnier
  2013-07-26  9:51     ` Juanma Barranquero
@ 2013-07-26  9:51     ` Juanma Barranquero
  2013-07-26 13:36     ` Dmitry Gutov
  2013-07-26 13:36     ` Dmitry Gutov
  3 siblings, 0 replies; 14+ messages in thread
From: Juanma Barranquero @ 2013-07-26  9:51 UTC (permalink / raw)
  To: Stefan Monnier
  Cc: 14948-done, Matthias Meulien, Dmitry Gutov, Emacs developers

On Fri, Jul 26, 2013 at 9:53 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:

> Could someone install his patch, please?

Done as revno:113554





^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: bug#14948: Key binding to print VC root log from VC dir
  2013-07-26  7:53   ` Stefan Monnier
@ 2013-07-26  9:51     ` Juanma Barranquero
  2013-07-26  9:51     ` Juanma Barranquero
                       ` (2 subsequent siblings)
  3 siblings, 0 replies; 14+ messages in thread
From: Juanma Barranquero @ 2013-07-26  9:51 UTC (permalink / raw)
  To: Stefan Monnier
  Cc: 14948-done, Matthias Meulien, Dmitry Gutov, Emacs developers

On Fri, Jul 26, 2013 at 9:53 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:

> Could someone install his patch, please?

Done as revno:113554



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Key binding to print VC root log from VC dir
  2013-07-25 16:53 ` Glenn Morris
@ 2013-07-26 10:53   ` Matthias Meulien
  0 siblings, 0 replies; 14+ messages in thread
From: Matthias Meulien @ 2013-07-26 10:53 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

> (...) FYIs:
> Since the above items were not on separate lines, they had no effect.
> Also, there is no need to send things to both emacs-devel and
> bug-gnu-emacs.

Thanks, I'll take care.
-- 
Matthias



^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14948: Key binding to print VC root log from VC dir
  2013-07-26  7:53   ` Stefan Monnier
  2013-07-26  9:51     ` Juanma Barranquero
  2013-07-26  9:51     ` Juanma Barranquero
@ 2013-07-26 13:36     ` Dmitry Gutov
  2013-07-26 13:36     ` Dmitry Gutov
  3 siblings, 0 replies; 14+ messages in thread
From: Dmitry Gutov @ 2013-07-26 13:36 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 14948, Matthias Meulien, Dmitry Gutov, emacs-devel

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
> duplicate `C-x v L' as `L' as his patch suggests.

I see.
Shall we add a similar 'D' binding for `vc-root-diff'?





^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: bug#14948: Key binding to print VC root log from VC dir
  2013-07-26  7:53   ` Stefan Monnier
                       ` (2 preceding siblings ...)
  2013-07-26 13:36     ` Dmitry Gutov
@ 2013-07-26 13:36     ` Dmitry Gutov
  2013-07-26 15:10       ` Stefan Monnier
  2013-07-26 15:10       ` Stefan Monnier
  3 siblings, 2 replies; 14+ messages in thread
From: Dmitry Gutov @ 2013-07-26 13:36 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel, Matthias Meulien, Dmitry Gutov, 14948

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
> duplicate `C-x v L' as `L' as his patch suggests.

I see.
Shall we add a similar 'D' binding for `vc-root-diff'?



^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14948: Key binding to print VC root log from VC dir
  2013-07-26 13:36     ` Dmitry Gutov
@ 2013-07-26 15:10       ` Stefan Monnier
  2013-07-26 15:10       ` Stefan Monnier
  1 sibling, 0 replies; 14+ messages in thread
From: Stefan Monnier @ 2013-07-26 15:10 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: 14948, Matthias Meulien, emacs-devel

>> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
>> duplicate `C-x v L' as `L' as his patch suggests.
> I see.
> Shall we add a similar 'D' binding for `vc-root-diff'?

That would make sense.


        Stefan





^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: bug#14948: Key binding to print VC root log from VC dir
  2013-07-26 13:36     ` Dmitry Gutov
  2013-07-26 15:10       ` Stefan Monnier
@ 2013-07-26 15:10       ` Stefan Monnier
  1 sibling, 0 replies; 14+ messages in thread
From: Stefan Monnier @ 2013-07-26 15:10 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: emacs-devel, Matthias Meulien, 14948

>> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
>> duplicate `C-x v L' as `L' as his patch suggests.
> I see.
> Shall we add a similar 'D' binding for `vc-root-diff'?

That would make sense.


        Stefan



^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14948: Key binding to print VC root log from VC dir
  2013-07-24 21:41 Key binding to print VC root log from VC dir Matthias Meulien
  2013-07-25 16:53 ` Glenn Morris
  2013-07-26  7:18 ` bug#14948: " Dmitry Gutov
@ 2013-07-27  0:11 ` Xue Fuqiao
  2013-07-27 11:57   ` Dmitry Gutov
  2 siblings, 1 reply; 14+ messages in thread
From: Xue Fuqiao @ 2013-07-27  0:11 UTC (permalink / raw)
  To: 14948-done

Done as revision 113563, thanks.

--
Best regards, Xue Fuqiao.





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14948: Key binding to print VC root log from VC dir
  2013-07-27  0:11 ` Xue Fuqiao
@ 2013-07-27 11:57   ` Dmitry Gutov
  0 siblings, 0 replies; 14+ messages in thread
From: Dmitry Gutov @ 2013-07-27 11:57 UTC (permalink / raw)
  To: Xue Fuqiao; +Cc: 14948-done

Xue Fuqiao <xfq.free@gmail.com> writes:

> Done as revision 113563, thanks.

Thank you. It has actually been a "paper cut" bug for me for a while.





^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2013-07-27 11:57 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-24 21:41 Key binding to print VC root log from VC dir Matthias Meulien
2013-07-25 16:53 ` Glenn Morris
2013-07-26 10:53   ` Matthias Meulien
2013-07-26  7:18 ` bug#14948: " Dmitry Gutov
2013-07-26  7:53   ` Stefan Monnier
2013-07-26  7:53   ` Stefan Monnier
2013-07-26  9:51     ` Juanma Barranquero
2013-07-26  9:51     ` Juanma Barranquero
2013-07-26 13:36     ` Dmitry Gutov
2013-07-26 13:36     ` Dmitry Gutov
2013-07-26 15:10       ` Stefan Monnier
2013-07-26 15:10       ` Stefan Monnier
2013-07-27  0:11 ` Xue Fuqiao
2013-07-27 11:57   ` Dmitry Gutov

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.