From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#14944: 24.3.50; Cygw32 build break Date: Wed, 24 Jul 2013 07:42:14 -0400 Message-ID: <51EFBD96.3060206@cornell.edu> References: <878v0wp6jn.wl%%xmue@d1.dion.ne.jp> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1374666194 16099 80.91.229.3 (24 Jul 2013 11:43:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Jul 2013 11:43:14 +0000 (UTC) Cc: 14944@debbugs.gnu.org, Paul Eggert To: Kazuhiro Ito Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 24 13:43:14 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V1xTN-0007rZ-QI for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jul 2013 13:43:13 +0200 Original-Received: from localhost ([::1]:48759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1xTN-0004Zs-BB for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jul 2013 07:43:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1xTK-0004Zn-GF for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 07:43:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1xTD-0002si-74 for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 07:43:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1xTD-0002sd-3y for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 07:43:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V1xTC-0003pc-9X for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 07:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2013 11:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14944 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14944-submit@debbugs.gnu.org id=B14944.137466615414650 (code B ref 14944); Wed, 24 Jul 2013 11:43:02 +0000 Original-Received: (at 14944) by debbugs.gnu.org; 24 Jul 2013 11:42:34 +0000 Original-Received: from localhost ([127.0.0.1]:46611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1xSk-0003oE-Dz for submit@debbugs.gnu.org; Wed, 24 Jul 2013 07:42:34 -0400 Original-Received: from limerock04.mail.cornell.edu ([128.84.12.60]:38354) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1xSh-0003nx-VN for 14944@debbugs.gnu.org; Wed, 24 Jul 2013 07:42:33 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id r6OBgLDI029954; Wed, 24 Jul 2013 07:42:21 -0400 Original-Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r6OBgJPd029004 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Jul 2013 07:42:20 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 In-Reply-To: <878v0wp6jn.wl%%xmue@d1.dion.ne.jp> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76620 Archived-At: On 7/24/2013 6:59 AM, Kazuhiro Ito wrote: > Because make_save_ptr is not defined in Cygw32, Cygw32 can't be built > on trunk. > > (snip) > w32fns.o: In function `w32_monitor_enum': > /build/emacs/trunk/src/w32fns.c:4933: undefined reference to `make_save_ptr' > collect2: error: ld returned 1 exit status > (snip) > > > make_save_ptr is defined as below in src/alloc.c > > #if defined HAVE_NS || defined DOS_NT > Lisp_Object > make_save_ptr (void *a) > { > Lisp_Object val = allocate_misc (Lisp_Misc_Save_Value); > struct Lisp_Save_Value *p = XSAVE_VALUE (val); > p->save_type = SAVE_POINTER; > p->data[0].pointer = a; > return val; > } > #endif This happened because of a change in rev 113453, in which make_save_ptr (formerly called make_save_pointer) was defined only on platforms that need it. The cygw32 platform was missed. The following should fix it. === modified file 'src/alloc.c' --- src/alloc.c 2013-07-21 15:56:55 +0000 +++ src/alloc.c 2013-07-24 11:35:40 +0000 @@ -3371,7 +3371,7 @@ return val; } -#if defined HAVE_NS || defined DOS_NT +#if defined HAVE_NS || defined DOS_NT || defined HAVE_NTGUI Lisp_Object make_save_ptr (void *a) { Ken