From: Ken Brown <kbrown@cornell.edu>
To: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
Cc: 14944@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#14944: 24.3.50; Cygw32 build break
Date: Wed, 24 Jul 2013 07:42:14 -0400 [thread overview]
Message-ID: <51EFBD96.3060206@cornell.edu> (raw)
In-Reply-To: <878v0wp6jn.wl%%xmue@d1.dion.ne.jp>
On 7/24/2013 6:59 AM, Kazuhiro Ito wrote:
> Because make_save_ptr is not defined in Cygw32, Cygw32 can't be built
> on trunk.
>
> (snip)
> w32fns.o: In function `w32_monitor_enum':
> /build/emacs/trunk/src/w32fns.c:4933: undefined reference to `make_save_ptr'
> collect2: error: ld returned 1 exit status
> (snip)
>
>
> make_save_ptr is defined as below in src/alloc.c
>
> #if defined HAVE_NS || defined DOS_NT
> Lisp_Object
> make_save_ptr (void *a)
> {
> Lisp_Object val = allocate_misc (Lisp_Misc_Save_Value);
> struct Lisp_Save_Value *p = XSAVE_VALUE (val);
> p->save_type = SAVE_POINTER;
> p->data[0].pointer = a;
> return val;
> }
> #endif
This happened because of a change in rev 113453, in which make_save_ptr
(formerly called make_save_pointer) was defined only on platforms that
need it. The cygw32 platform was missed. The following should fix it.
=== modified file 'src/alloc.c'
--- src/alloc.c 2013-07-21 15:56:55 +0000
+++ src/alloc.c 2013-07-24 11:35:40 +0000
@@ -3371,7 +3371,7 @@
return val;
}
-#if defined HAVE_NS || defined DOS_NT
+#if defined HAVE_NS || defined DOS_NT || defined HAVE_NTGUI
Lisp_Object
make_save_ptr (void *a)
{
Ken
next prev parent reply other threads:[~2013-07-24 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 10:59 bug#14944: 24.3.50; Cygw32 build break Kazuhiro Ito
2013-07-24 11:42 ` Ken Brown [this message]
2013-07-24 14:38 ` Eli Zaretskii
2013-07-24 15:12 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EFBD96.3060206@cornell.edu \
--to=kbrown@cornell.edu \
--cc=14944@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=kzhr@d1.dion.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.