From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900) Date: Wed, 30 Oct 2024 22:37:02 -0700 Message-ID: <51E22B78-C0E5-4B4E-B501-C1613FB4720A@gmail.com> References: <173018710062.2953743.6862996178790876925@vcs3.savannah.gnu.org> <20241029073141.19F3A3747EE@vcs3.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10641"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 31 06:38:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6Nsq-0002Vt-47 for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Oct 2024 06:38:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6Ns8-00014r-Jj; Thu, 31 Oct 2024 01:37:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6Ns0-00011D-MB for emacs-devel@gnu.org; Thu, 31 Oct 2024 01:37:21 -0400 Original-Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6Nrx-00059J-0V; Thu, 31 Oct 2024 01:37:18 -0400 Original-Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3e5f835c024so366643b6e.2; Wed, 30 Oct 2024 22:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730353034; x=1730957834; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8k1UXmGaYTwJDwHKMkVv6awZ9ZHf23RU7EX6qEoRPpc=; b=DikN9SAIgDJlVO08QkfL/vtF7E0TodtbchToo7UD1T6CS/4dYuApXeHVFdebW35HKG cqFzVbs0AW1OtUjm845JKk0arqjuonIQwSeZCCldt54lMmaMceRd0Hduk2KZshoNQ3Vq TbqiA5qUiyQ2ykF21D20nzurJ4rUtXdfKN0nEBck4jFI0Cf9h2+E6Yv0SVqZ+wON+p1F O/8du9iQ+LjVF8hqS0q2xjg48DWB0GFAWnkR03P/ORD9ejtjWLzvoDCL9PjLN/7v7qvx h+4PcURYfwE4DepPvfzMhyAUdxY66ynu489wPMUS7eksuu11WgAZZOfKQtH14jnh9zk3 s32g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730353034; x=1730957834; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8k1UXmGaYTwJDwHKMkVv6awZ9ZHf23RU7EX6qEoRPpc=; b=bploxePWHtnbN2UYvmBBzQwYe19Um7621J09LCpVxxF+0AMSvpvIYjZvUpyMSihL7C 7MmZ7lh87GYjuvM/l1pWIRCh2c9ZYOUw+klN0uNaSxgeMcZARZU7+rCT3uwMc9RIP2mu tF05TLLV6uNdalLfgJAGRNt7St0P2TGw7E+VRo5+Otm6GFAMLAF6Bn7gTKOHNC8z2igf i6RZ29slwUMPKqGYcj6XRNR5eZS1myEr1gSFOq9daMM5J/px3HP3CuOt2Y8LwQh5I7pz I1Mu2dm4i6w9a1N4T4G9i17P4qE803F99BYR13LFNTAuQ117Ourlx1GVNX4mTvFaueWe 7nFQ== X-Gm-Message-State: AOJu0Yy6/aP147htc7VAnmiTPrIbzZHXYo/nK7pALtydlHMZUU0V7dip 7ZEL5B4c4pVZWayLpZhpRC7MHvAePFCftfaQPVnSplAFfahVUzZHGyz3Ktn1 X-Google-Smtp-Source: AGHT+IHx1+wqZPpIBxSa4bqFUl3eK41B692MDVHZIkIQAJCfjO0tqWvyxQOh8ioJ6YeXlTP2JbbErA== X-Received: by 2002:a05:6808:3a0f:b0:3e6:4038:9b0d with SMTP id 5614622812f47-3e640389dabmr16488438b6e.39.1730353033970; Wed, 30 Oct 2024 22:37:13 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:e48b:e566:9832:af15]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ee45a0ec8bsm457160a12.79.2024.10.30.22.37.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Oct 2024 22:37:13 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3776.700.51) Received-SPF: pass client-ip=2607:f8b0:4864:20::22e; envelope-from=casouri@gmail.com; helo=mail-oi1-x22e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324954 Archived-At: > On Oct 30, 2024, at 7:17=E2=80=AFAM, Andrea Corallo = wrote: >=20 > Yuan Fu writes: >=20 >> branch: master >> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96 >> Author: Yuan Fu >> Commit: Yuan Fu >>=20 >> Fix c-ts-common-comment-indent-new-line (bug#73900) >>=20 >> * lisp/progmodes/c-ts-common.el: >> (c-ts-common-comment-indent-new-line): Delete trailing >> whitespace before inserting newline. The insert-line-break >> function is the same as in c-indent-new-comment-line. >> --- >> lisp/progmodes/c-ts-common.el | 104 = ++++++++++++++++++++++-------------------- >> 1 file changed, 55 insertions(+), 49 deletions(-) >=20 > Hi Yuan, >=20 > I believe this is introducing the following building master: >=20 > progmodes/c-ts-common.el:339:27: Warning: reference to free variable = =E2=80=98allow-auto-fill=E2=80=99 >=20 > IIUC some code was imported in 'c-ts-common-comment-indent-new-line' > from 'c-indent-new-comment-line' but in the latter the interface > includes the 'allow-auto-fill' optional parameter. >=20 > Would you mind having a look? >=20 > Please always check that the build is clean before installing a = change. >=20 > Thanks >=20 > Andrea Yes, thanks for the notice. And apologies :( It should be fixed now. Yuan=