From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#14821: Build broken on 64-bit Cygwin starting with bzr revision 113315 Date: Tue, 09 Jul 2013 09:28:03 -0400 Message-ID: <51DC0FE3.305@cornell.edu> References: <51DADF18.5050006@cornell.edu> <51DC02FF.60003@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1373376549 20680 80.91.229.3 (9 Jul 2013 13:29:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Jul 2013 13:29:09 +0000 (UTC) Cc: Paul Eggert To: 14821@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 09 15:29:09 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UwXyf-0007zz-64 for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2013 15:29:09 +0200 Original-Received: from localhost ([::1]:34759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwXye-0000hm-P5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2013 09:29:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwXyb-0000hJ-C8 for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 09:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwXya-0000Tz-49 for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 09:29:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwXya-0000Tq-0e for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 09:29:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UwXyY-0006GH-SJ for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 09:29:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14821 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14821-submit@debbugs.gnu.org id=B14821.137337649923948 (code B ref 14821); Tue, 09 Jul 2013 13:29:02 +0000 Original-Received: (at 14821) by debbugs.gnu.org; 9 Jul 2013 13:28:19 +0000 Original-Received: from localhost ([127.0.0.1]:41902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwXxq-0006E7-23 for submit@debbugs.gnu.org; Tue, 09 Jul 2013 09:28:18 -0400 Original-Received: from limerock04.mail.cornell.edu ([128.84.12.60]:60163) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwXxk-0006DQ-Ta for 14821@debbugs.gnu.org; Tue, 09 Jul 2013 09:28:13 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id r69DS1BV001186; Tue, 9 Jul 2013 09:28:01 -0400 Original-Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r69DS03a019715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 9 Jul 2013 09:28:00 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 In-Reply-To: <51DC02FF.60003@cornell.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76128 Archived-At: On 7/9/2013 8:33 AM, Ken Brown wrote: > But the point is that setmode shouldn't be used on Cygwin (and wasn't > prior to revision 113315). > > The following patch allows the build to complete, but I don't know if > it's the right fix: > > === modified file 'lib/pipe2.c' > --- lib/pipe2.c 2013-07-07 18:00:14 +0000 > +++ lib/pipe2.c 2013-07-09 12:20:47 +0000 > @@ -138,7 +138,7 @@ > goto fail; > } > > -# if O_BINARY > +# if O_BINARY && !defined (CYGWIN) > if (flags & O_BINARY) > { > setmode (fd[1], O_BINARY); On second thought, instead of the negative '!defined (CYGWIN)', the code should probably explicitly list the platforms on which setmode *should* be used. This is how it's done in other uses of setmode. Ken