From: Ken Brown <kbrown@cornell.edu>
To: 14821@debbugs.gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#14821: Build broken on 64-bit Cygwin starting with bzr revision 113315
Date: Tue, 09 Jul 2013 09:28:03 -0400 [thread overview]
Message-ID: <51DC0FE3.305@cornell.edu> (raw)
In-Reply-To: <51DC02FF.60003@cornell.edu>
On 7/9/2013 8:33 AM, Ken Brown wrote:
> But the point is that setmode shouldn't be used on Cygwin (and wasn't
> prior to revision 113315).
>
> The following patch allows the build to complete, but I don't know if
> it's the right fix:
>
> === modified file 'lib/pipe2.c'
> --- lib/pipe2.c 2013-07-07 18:00:14 +0000
> +++ lib/pipe2.c 2013-07-09 12:20:47 +0000
> @@ -138,7 +138,7 @@
> goto fail;
> }
>
> -# if O_BINARY
> +# if O_BINARY && !defined (CYGWIN)
> if (flags & O_BINARY)
> {
> setmode (fd[1], O_BINARY);
On second thought, instead of the negative '!defined (CYGWIN)', the code
should probably explicitly list the platforms on which setmode *should*
be used. This is how it's done in other uses of setmode.
Ken
next prev parent reply other threads:[~2013-07-09 13:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 15:47 bug#14821: Build broken on 64-bit Cygwin starting with bzr revision 113315 Ken Brown
2013-07-09 12:33 ` Ken Brown
2013-07-09 13:28 ` Ken Brown [this message]
2013-07-09 16:17 ` Eli Zaretskii
2013-07-09 16:46 ` Ken Brown
2013-07-09 17:07 ` Eli Zaretskii
2013-07-09 17:13 ` Ken Brown
2013-07-09 17:29 ` Paul Eggert
2013-07-09 19:52 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DC0FE3.305@cornell.edu \
--to=kbrown@cornell.edu \
--cc=14821@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.