From: Dmitry Gutov <dgutov@yandex.ru>
To: Bozhidar Batsov <bozhidar@batsov.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Small improvements to ruby-mode
Date: Tue, 02 Jul 2013 22:38:10 +0400 [thread overview]
Message-ID: <51D31E12.7060002@yandex.ru> (raw)
In-Reply-To: <CAM9Zgm3Uw-TfW9aT7zdA1r=etsb26xAcW7DHJ_7=NfArFE8e5A@mail.gmail.com>
Hmm, I don't see either of these problems with the current trunk. Have
you checked for stale ruby-mode.elc or a rogue ruby-mode.el installed
via ELPA?
I did encounter the following semi-known issue:
Putting the cursor on one of the 4 lines after "elsif" in the second
example and pressing `C-M-p' moves it to the "add_offence" line.
And pressing `C-M-n' after that moves it to the "end" closing the
"operands.each" block.
Pressing `C-M-p' or `C-M-n' on the `elsif' line misbehaves similarly.
I'll see about fixing that.
On 02.07.2013 19:46, Bozhidar Batsov wrote:
> Here's a bit of code:
>
> operands.each do |op|
> if LITERALS.include?(op.type)
> add_offence(:warning, op.loc.expression,
> format(MSG, op.loc.expression.source))
>
> end
> end
>
> Placing the cursor somewhere in the `if` yields totally crazy results
> (or even errors from time to time - "setq: Wrong type argument:
> number-or-marker-p, nil") when calling `ruby-beginning-of-block` and
> `ruby-end-of-block`. I'd expect `ruby-beginning-of-block` to go to the
> `each` line and `ruby-beginning-of-block` to go to the `end` of the
> block in question. There's also the question if constructs ending with
> an `end` should be treated as blocks as well - that might be useful to
> develop scope highlighting tools without a lot of custom code.
def-end, if-end, etc, are already treated as blocks.
> Regarding the other problem I mentioned - mark defun doesn't always work
> correctly:
>
> def check_for_literal(node)
> cond, = *node
>
> # if the code node is literal we obviously have a problem
> if LITERALS.include?(cond.type)
> add_offence(:warning, cond.loc.expression,
> format(MSG, cond.loc.expression.source))
> elsif [:and, :or].include?(cond.type)
> # alternatively we have to consider a logical node with a
> # literal argument
> *operands = *cond
> operands.each do |op|
> if LITERALS.include?(op.type)
> add_offence(:warning, op.loc.expression,
> format(MSG, op.loc.expression.source))
>
> end
> end
> end
> end
>
> Place the cursor inside the innermost `if` near the end of the defun and
> try `C-M-h` there - you'll see that only a portion of the defun will be
> marked.
`mark-defun' call `beginning-of-defun' and `end-of-defun', and they work
pretty reliably here.
next prev parent reply other threads:[~2013-07-02 18:38 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 16:00 Small improvements to ruby-mode Bozhidar Batsov
2013-06-21 19:10 ` Stefan Monnier
2013-06-21 23:31 ` Dmitry Gutov
2013-06-21 23:45 ` Glenn Morris
2013-06-22 0:12 ` Dmitry Gutov
2013-06-22 7:05 ` Bozhidar Batsov
2013-06-22 13:28 ` Dmitry Gutov
2013-06-22 15:30 ` Stefan Monnier
2013-06-23 6:20 ` Bozhidar Batsov
2013-06-23 12:30 ` Dmitry Gutov
2013-06-24 13:49 ` Bozhidar Batsov
2013-07-01 18:32 ` Dmitry Gutov
2013-07-01 21:41 ` Bozhidar Batsov
2013-07-01 21:50 ` Dmitry Gutov
[not found] ` <CAM9Zgm3Uw-TfW9aT7zdA1r=etsb26xAcW7DHJ_7=NfArFE8e5A@mail.gmail.com>
2013-07-02 18:38 ` Dmitry Gutov [this message]
2013-07-03 15:46 ` Dmitry Gutov
[not found] ` <CAM9Zgm1_Jmn7Z4ZwSkPURAFOdTCURQP-TEDeys0dR4Uqyr8mfw@mail.gmail.com>
2013-07-05 10:30 ` Dmitry Gutov
2013-07-05 11:08 ` Stefan Monnier
2013-07-05 11:55 ` Dmitry Gutov
2013-07-05 22:18 ` Stefan Monnier
2013-07-05 13:01 ` Bozhidar Batsov
2013-07-05 14:15 ` Dmitry Gutov
2013-07-06 5:31 ` Bozhidar Batsov
2013-07-06 9:37 ` Dmitry Gutov
2013-07-06 12:23 ` Bozhidar Batsov
2013-07-06 15:47 ` Dmitry Gutov
2013-07-07 21:56 ` Stefan Monnier
2013-07-07 23:22 ` Dmitry Gutov
2013-07-08 9:22 ` Stefan Monnier
2013-07-09 0:40 ` Dmitry Gutov
2013-07-09 8:50 ` Stefan Monnier
2013-07-09 12:57 ` Bozhidar Batsov
2013-07-08 9:33 ` Bozhidar Batsov
2013-07-08 9:37 ` Bozhidar Batsov
2013-07-09 1:19 ` Dmitry Gutov
2013-07-09 12:55 ` Bozhidar Batsov
2013-07-09 14:36 ` Bozhidar Batsov
2013-07-09 16:07 ` Bozhidar Batsov
2013-07-09 17:18 ` Dmitry Gutov
2013-07-10 6:23 ` Bozhidar Batsov
2013-07-09 17:09 ` Dmitry Gutov
2013-07-10 6:09 ` Bozhidar Batsov
2013-07-10 18:09 ` Dmitry Gutov
2013-07-11 11:23 ` Bozhidar Batsov
2013-07-12 20:31 ` Dmitry Gutov
[not found] ` <CAM9Zgm2NbtNkm8p+SL=kYd-u90r5ELTvJrj4rxm8_Yk5QVN4WA@mail.gmail.com>
2013-07-13 10:24 ` Bozhidar Batsov
2013-07-13 19:10 ` Dmitry Gutov
2013-07-15 13:53 ` Bozhidar Batsov
2013-07-16 13:18 ` Bozhidar Batsov
2013-07-16 14:47 ` Dmitry Gutov
2013-08-08 15:56 ` Bozhidar Batsov
2013-08-08 21:21 ` Dmitry Gutov
2013-08-08 22:47 ` Stefan Monnier
2013-08-08 23:54 ` Dmitry Gutov
2013-08-09 14:52 ` Stefan Monnier
2013-08-10 11:45 ` Dmitry Gutov
2013-08-10 13:23 ` Stefan Monnier
2013-08-11 11:54 ` Bozhidar Batsov
2013-08-11 13:08 ` Dmitry Gutov
2013-08-11 14:08 ` Johan Andersson
2013-08-11 14:29 ` Dmitry Gutov
2013-08-11 15:18 ` Johan Andersson
2013-08-11 16:56 ` Stefan Monnier
2013-08-11 20:55 ` Johan Andersson
2013-08-12 1:52 ` Stefan Monnier
2013-09-13 9:10 ` Bozhidar Batsov
2013-09-13 9:26 ` Johan Andersson
2013-09-13 13:24 ` Stefan Monnier
2013-09-13 13:27 ` Johan Andersson
2013-07-05 22:35 ` Stefan Monnier
2013-07-06 5:14 ` Bozhidar Batsov
2013-07-06 9:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D31E12.7060002@yandex.ru \
--to=dgutov@yandex.ru \
--cc=bozhidar@batsov.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.