From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Daniel Hackney <dan@haxney.org>,
Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar!
Date: Tue, 25 Jun 2013 03:38:49 +0400 [thread overview]
Message-ID: <51C8D889.5000404@yandex.ru> (raw)
In-Reply-To: <jwvobazcy4q.fsf-monnier+emacs@gnu.org>
On 21.06.2013 18:56, Stefan Monnier wrote:
>> AFAICT, you've omitted the whole "automated testing" part of the
>> changes, which was one of the main things I liked personally.
>
> I indeed focused on the package.el part itself, since that was the
> problematic part (where there was no clear description of what the
> patch was trying to do).
>
>> Any particular reason?
>
> No, oversight only. Feel free to add it.
Just an update, I've tried to bring the tests over today, but they're
quite dependent on the implementation.
I still have 6/10 failures, so far.
One thing I've noticed that you omitted is the inclusion of the
"commentary" field in the package-desc struct.
Not sure what the justification for its inclusion was, but I've had to
remove the related assertions from the test file.
Daniel:
One thing I definitely didn't like is the usage of raw cl-struct vectors
as reference values to compare against. These are implementation details
of cl-defstruct, and we have no business setting them in stone in a test
suite for code that just uses defstruct.
Relying on an external program (ginstall-info) is also not nice, for the
usual alternative-OS-related reasons.
next prev parent reply other threads:[~2013-06-24 23:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 18:44 cl-defstruct-based package.el, now with ert tests and no external tar! Daniel Hackney
2013-04-04 1:55 ` Stefan Monnier
2013-04-05 16:32 ` Dmitry Gutov
2013-04-05 19:21 ` Stefan Monnier
2013-04-05 20:51 ` Daniel Hackney
2013-04-06 21:02 ` Ted Zlatanov
2013-04-07 0:43 ` Stefan Monnier
[not found] ` <jwv7gjt4arv.fsf-monnier+emacs@gnu.org>
2013-04-25 2:52 ` Daniel Hackney
2013-06-01 19:39 ` Dmitry Gutov
2013-06-04 21:25 ` Daniel Hackney
2013-06-05 15:10 ` Ted Zlatanov
2013-06-05 21:42 ` Dmitry Gutov
2013-06-24 12:44 ` Sebastian Wiesner
2013-06-25 1:19 ` Stefan Monnier
2013-06-25 12:19 ` Sebastian Wiesner
2013-06-25 13:58 ` Stefan Monnier
2013-06-25 17:32 ` Sebastian Wiesner
2013-06-25 18:23 ` Stefan Monnier
2013-06-25 20:43 ` Sebastian Wiesner
2013-06-26 0:28 ` Stefan Monnier
2013-06-25 22:07 ` Daniel Hackney
2013-06-26 23:04 ` Nic Ferrier
[not found] ` <CAMqXDZtwnS-qUs8vCghYun0JZVuzofy4sCTMqdSskB2jJ9fq=g@mail.gmail.com>
[not found] ` <jwvobd3mg6l.fsf-monnier+emacs@gnu.org>
2013-06-12 2:18 ` Stefan Monnier
2013-06-21 4:20 ` Stefan Monnier
2013-06-21 7:49 ` Dmitry Gutov
2013-06-21 14:56 ` Stefan Monnier
2013-06-24 23:38 ` Dmitry Gutov [this message]
2013-06-25 21:49 ` Daniel Hackney
2013-06-26 7:35 ` Dmitry Gutov
2013-06-27 9:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C8D889.5000404@yandex.ru \
--to=dgutov@yandex.ru \
--cc=dan@haxney.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.