From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#14474: Using glib's g_file_monitor_file and g_file_monitor_directory Date: Fri, 31 May 2013 12:24:52 -0700 Message-ID: <51A8F904.8000808@cs.ucla.edu> References: <87zjxxn6th.fsf@gmx.de> <87hajqpjn1.fsf@gmx.de> <8738t7pewc.fsf@gmx.de> <51A4C2E9.8040000@cs.ucla.edu> <87vc63nlje.fsf@gmx.de> <51A4FFAD.20202@cs.ucla.edu> <87obbuc0dy.fsf@gmx.de> <51A515B8.4040405@cs.ucla.edu> <87bo7ub9go.fsf@gmx.de> <51A80019.90900@cs.ucla.edu> <874ndjat9z.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1370028334 7804 80.91.229.3 (31 May 2013 19:25:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 May 2013 19:25:34 +0000 (UTC) Cc: 14474@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 31 21:25:33 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UiUxA-0001E6-4v for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 May 2013 21:25:32 +0200 Original-Received: from localhost ([::1]:52230 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiUx9-0005tQ-Oa for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 May 2013 15:25:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiUx4-0005tB-Ta for bug-gnu-emacs@gnu.org; Fri, 31 May 2013 15:25:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiUx3-0006Xb-Vy for bug-gnu-emacs@gnu.org; Fri, 31 May 2013 15:25:26 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiUx3-0006XU-SQ for bug-gnu-emacs@gnu.org; Fri, 31 May 2013 15:25:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UiUyb-00059q-OH for bug-gnu-emacs@gnu.org; Fri, 31 May 2013 15:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 May 2013 19:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14474 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14474-submit@debbugs.gnu.org id=B14474.137002840519785 (code B ref 14474); Fri, 31 May 2013 19:27:01 +0000 Original-Received: (at 14474) by debbugs.gnu.org; 31 May 2013 19:26:45 +0000 Original-Received: from localhost ([127.0.0.1]:45027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiUyL-000592-5o for submit@debbugs.gnu.org; Fri, 31 May 2013 15:26:45 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:38197) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiUyI-00058R-1O for 14474@debbugs.gnu.org; Fri, 31 May 2013 15:26:44 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 72A2CA60001; Fri, 31 May 2013 12:24:58 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VXw2CW+U49zl; Fri, 31 May 2013 12:24:58 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id DD20F39E8008; Fri, 31 May 2013 12:24:57 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 In-Reply-To: <874ndjat9z.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74716 Archived-At: On 05/31/13 11:39, Michael Albinus wrote: > You've put the lines inside #ifdef USE_GTK. However, glib could be > linked to Emacs without using gtk. We might need another check, like > #ifdef USE_GLIB. This would be useful in other places, too. That might make sense in the long run, if Emacs is built that way. But as I understand it, currently Emacs links to glib only when using Gtk, so the workaround is OK under the current framework. > Furthermore, I'd wrap these lines with #ifdef HAVE_DBUS. If Emacs is > compiled without D-Bus support, external processes could still use > D-Bus via autolaunch. You suppress this possibility by overwriting > $DBUS_SESSION_BUS_ADDRESS. Can't the Emacs process autolaunch D-bus subprocesses even when it HAVE_DBUS is not defined? That is, some other toolkit that Emacs links to, could autolaunch D-Bus. So it wouldn't be safe to wrap the lines with #ifdef HAVE_DBUS. I do see the problem that you mention. I think a better fix, though, is to redo Emacs to use the glib child watcher code -- that will fix the problem that you mention, along with the problem for Emacs itself.