all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Klein <kleinrob@mpip-mainz.mpg.de>
To: emacs-orgmode@gnu.org, Rasmus <rasmus@gmx.us>
Subject: Re: [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4])
Date: Sat, 25 May 2013 07:13:33 +0200	[thread overview]
Message-ID: <51A0487D.4020809@mpip-mainz.mpg.de> (raw)
In-Reply-To: <20130522220650.GB68001@kenny.local>

Hi,

FWIW, from a users view it would be nice if:

- Use Author/Email information from org file
- If not present use information from LCO file
- if neither org file nor LCO file has any information use
  user-full-name and user-email-address

Could this be solved by having several e.g. `setkomavar{fromname}'
and so on in the tex file, so is created as follows:


if no #+AUTHOR in org-file and user-full-name is set:
    add user-full-name
if #+LCO(s) in org-file:
    add LCO file(s)
if #+AUTHOR in org-file:
    add \setkomavar{fromname}{#+AUTHOR}
....  same for email
add \setkomavar{signature}{\usekomavar{fromname}}


so the result tex file may have:


\setkomavar{fromname}{Hans Wurst}
\setkomavar{fromemail}{hans_wurst@example.com}
...
\setkomavar{fromname}{Reiner Zufall}
\setkomavar{fromemail}{reiner_zufall@example.com}
\setkomavar{signature}{\usekomavar{fromname}}


This probably isn't a `clean' solution, but should work without a need
to grep LCO files.

Best regards
Robert


On 05/23/2013 12:06 AM, Viktor Rosenfeld wrote:
> Hi Rasmus,
> 
> Viktor Rosenfeld wrote:
> 
>> Hi Rasmus,
>>
>> Rasmus wrote:
>>
>>> Viktor Rosenfeld <listuser36@gmail.com> writes:
>>>
>>>> Or 5, keep the change from SENDER to AUTHOR but revert the default
>>>> values to `org-koma-letter-*' variables. (Right now the AUTHOR and EMAIL
>>>> lines could be removed because they duplicate the derived latex
>>>> backend.)
>>>
>>> I once had a teacher who talked about the optimal degree of
>>> conservatism (as well speaking positively about being in the infamoues
>>> ivory tower).  5. is fine with me.  So I guess the deal is
>>>   1. default value is the same as in ox-latex.
>>>   2. . . . but it's kept in a seperete variable ox-kl variable.
>>>
>>>> I think that switching from SENDER to AUTHOR, keeping the
>>>> `org-koma-letter-{author,email}' variables in the KOMA backend, but
>>>> setting them per default to `user-full-name' and `user-mail-address',
>>>> would solve both your problems and let me keep LCO files. I would then
>>>> simply set these `org-koma-letter-*' variables to `nil' and document
>>>> this setup in the docstring. I'll see tomorrow if this is feasable.
>>>
>>> Does the attached patch work for you (also with ps tags?)
>>
>> It works, but I noticed the following problem: According to the Emacs
>> documentation `user-mail-address' is only set by Emacs after the
>> initialization process has completed and if it is not explicitly set
>> during initialization [1]. So, the defcustom of org-koma-letter-email
>> does not work as expected if the user has not set `user-mail-address'
>> before. Instead it is set to the empty string, which according to the
>> code setting `user-mail-address' means "not set yet."
>>
>> This can be taking care of by using `after-init-hook' as in the example
>> below. It has the added advantage that the value of `user-mail-address'
>> will be picked up regardless of whether it is set before or after
>> require'ing ox-koma-letter. 
>>
>> Note that this creates a slight inconsistency with regard to
>> `user-full-name' which is only picked up correctly if it is set before
>> require'ing ox-koma-letter. I've fixed this by a slightly complicated
>> defcustom definition of `org-koma-letter-author' and another
>> after-init-hook.
>>
>> I've also changed the docstring to indicate what are the default values
>> and added the :group and :type flags again.
> 
> I've put my changes into a patch against the current master (commit
> 06cdb2d2). Could you check it with your setup?
> 
> Cheers,
> Viktor
> 

  reply	other threads:[~2013-05-25  5:13 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20  0:28 [patch] ox-koma-letter.el: credit [1/4] Rasmus
2013-05-20  0:40 ` [patch] ox-koma-letter.el: subject changes [2/4] Rasmus
2013-05-20 15:49   ` Alan Schmitt
2013-05-20 18:23     ` Rasmus
2013-05-21  7:24       ` Alan Schmitt
2013-05-21 15:52         ` Viktor Rosenfeld
2013-05-21 17:48           ` Rasmus
2013-05-20  0:51 ` [patch] ox-koma-letter.el: credit [3/4] Rasmus
2013-05-20 15:52   ` Alan Schmitt
2013-05-21 16:56   ` Viktor Rosenfeld
2013-05-21 17:35     ` Rasmus
2013-05-21 20:06       ` Viktor Rosenfeld
     [not found]         ` <87zjvo7xkl.fsf@pank.eu>
     [not found]           ` <20130522145312.GB61443@kenny.local>
2013-05-22 17:16             ` Rasmus
2013-05-22 17:38               ` Viktor Rosenfeld
2013-05-20  0:54 ` [patch] ox-koma-letter.el: clean-up/semantic bug [4/4] Rasmus
     [not found]   ` <m2ehd1tziq.fsf@polytechnique.org>
2013-05-21  9:05     ` Rasmus
2013-05-21 11:32       ` Alan Schmitt
2013-05-21 12:22         ` Rasmus
2013-05-21 17:02           ` Viktor Rosenfeld
2013-05-21 18:13             ` Rasmus
2013-05-21 19:54               ` Viktor Rosenfeld
2013-05-21 23:23                 ` Rasmus
2013-05-22 14:39                   ` Viktor Rosenfeld
2013-05-22 22:06                     ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Viktor Rosenfeld
2013-05-25  5:13                       ` Robert Klein [this message]
2013-05-25  8:05                         ` Viktor Rosenfeld
2013-05-25  9:20                           ` Alan Schmitt
2013-05-25 13:57                             ` Rasmus
2013-05-25 17:03                               ` Viktor Rosenfeld
2013-05-25 17:48                                 ` [PATCH][ox-koma-letter]: sender, email and cleanup (was: [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults) Rasmus
2013-05-25 21:27                                   ` [PATCH][ox-koma-letter]: sender, email and cleanup Rasmus
2013-05-26 10:58                                     ` Viktor Rosenfeld
2013-05-26 14:38                                       ` Rasmus
2013-05-26 10:54                                   ` [PATCH][ox-koma-letter]: sender, email and cleanup (was: [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults) Viktor Rosenfeld
2013-05-26 14:36                                     ` [PATCH][ox-koma-letter]: sender, email and cleanup Rasmus
2013-05-27  6:25                                       ` Alan Schmitt
2013-05-27  9:22                                         ` Xavier Garrido
2013-05-27  9:51                                           ` Rasmus
2013-05-27 18:31                                           ` Viktor Rosenfeld
2013-05-27 20:42                                             ` Xavier Garrido
2013-05-26 14:51                                     ` Rasmus
2013-05-25 20:51                               ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Robert Klein
2013-05-25 21:41                                 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults Rasmus
2013-05-26 11:04                                 ` [PATCH] ox-koma-letter.el: Reintroduce variables removed in commit 832c6fd with proper defaults (was Re: [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]) Viktor Rosenfeld
2013-05-20 15:44 ` [patch] ox-koma-letter.el: credit [1/4] Alan Schmitt
2013-05-20 15:49   ` Rasmus
2013-05-20 16:01     ` Alan Schmitt
2013-05-21 17:06 ` Viktor Rosenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A0487D.4020809@mpip-mainz.mpg.de \
    --to=kleinrob@mpip-mainz.mpg.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.