all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: James Cherti <contact@jamescherti.com>
To: help-gnu-emacs@gnu.org
Subject: Re: Run `window-configuration-change-hook` in Lisp code?
Date: Thu, 7 Nov 2024 00:35:05 -0500	[thread overview]
Message-ID: <5193f2dd-05ca-4a92-a3f9-2a069b8ad72e@jamescherti.com> (raw)
In-Reply-To: <jwvbjyr3b3h.fsf-monnier+emacs@gnu.org>

Hello Stefan,

Here is a summary of an email I sent to emacs-devel (Subject: Should 
text-scale trigger hooks?): I have identified an issue that affects 
Emacs packages such as eat (terminal) and visual-fill-column. Functions 
like `text-scale-increase`, `text-scale-decrease`, and `text-scale-set` 
do not trigger hooks like `window-configuration-change-hook`. As a 
result, the eat package does not immediately update the window when the 
text scale is changed, and visual-fill-column does not update the margin 
right away (it updates only after the window is resized).

The workaround to fix this issue is to call the following after the text 
scale is changed:
(run-hooks 'window-configuration-change-hook)

OP wants to know whether it is good practice or bad practice to run the 
`window-configuration-change-hook` hooks from a third-party package in 
this situation, as a workaround to resolve the issue described above. 
(Check: https://codeberg.org/joostkremers/visual-fill-column/pulls/16 ).

--
James Cherti
https://www.jamescherti.com/

On 2024-11-06 23:47, Stefan Monnier via Users list for the GNU Emacs 
text editor wrote:
>> Something that just came up: is it OK to run
>> `window-configuration-change-hook` in Lisp code? The doc string says
>> "Functions called during redisplay when window configuration has changed",
>> which gives me the impression that it's *only* meant to be run during
>> redisplay, i.e., not during Lisp code.
> 
> That description describes when the C code runs this hook.
> Do you want to run this hook yourself manually at other times?
> If so, why?
> 
> 
>          Stefan
> 
> 



  reply	other threads:[~2024-11-07  5:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06 19:40 Run `window-configuration-change-hook` in Lisp code? Joost Kremers
2024-11-07  4:47 ` Stefan Monnier via Users list for the GNU Emacs text editor
2024-11-07  5:35   ` James Cherti [this message]
2024-11-08 14:12     ` Stefan Monnier via Users list for the GNU Emacs text editor
2024-11-08 14:55       ` Joost Kremers
2024-11-08 17:55         ` Stefan Monnier
2024-11-08 15:51       ` James Cherti
2024-11-08 17:47         ` [External] : " Drew Adams
2024-11-07  7:24   ` Eli Zaretskii
2024-11-07  8:01     ` Joost Kremers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5193f2dd-05ca-4a92-a3f9-2a069b8ad72e@jamescherti.com \
    --to=contact@jamescherti.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.