From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#29321: Isearch hit count Date: Mon, 29 Oct 2018 19:43:49 -0700 (PDT) Message-ID: <518b2797-5991-4b08-ba00-29fcf5c8fbb6@default> References: <87o9bfqfc3.fsf@mail.linkov.net> <988284b2-58af-428d-9c6f-da56db0c6565@default> <874ld5elxb.fsf@mail.linkov.net> <3e52e081-ad81-41a6-a0d6-295790db82d4@default> <877ei049f6.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1540867397 29391 195.159.176.226 (30 Oct 2018 02:43:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Oct 2018 02:43:17 +0000 (UTC) Cc: charles@aurox.ch, 29321@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 30 03:43:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHJzo-0007Uk-Vc for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Oct 2018 03:43:09 +0100 Original-Received: from localhost ([::1]:50386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHK1v-0003Ad-BB for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Oct 2018 22:45:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHK1i-00038Q-M1 for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2018 22:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHK1e-0007DB-8u for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2018 22:45:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48422) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHK1e-0007D7-4U for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2018 22:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gHK1d-0006N6-S6 for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2018 22:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Oct 2018 02:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29321 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29321-submit@debbugs.gnu.org id=B29321.154086745124424 (code B ref 29321); Tue, 30 Oct 2018 02:45:01 +0000 Original-Received: (at 29321) by debbugs.gnu.org; 30 Oct 2018 02:44:11 +0000 Original-Received: from localhost ([127.0.0.1]:52680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHK0o-0006Lr-Ug for submit@debbugs.gnu.org; Mon, 29 Oct 2018 22:44:11 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:39272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHK0m-0006Ld-G5 for 29321@debbugs.gnu.org; Mon, 29 Oct 2018 22:44:09 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9U2cfZO135029; Tue, 30 Oct 2018 02:43:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=l6rDWFIHBYupRjS3X6h9izs8TGwhq0i2JV15pZpEikE=; b=psxflfmqaIyRfQCFkpGgDOvp02kcghk/vJFn/zUfkjYV6JlRERt/QcJGXyq/tzjh3FzL 8C6NYjRArY/uSuoT8wYLf+kx1sjI0FHbnDYEdeZPK/B7wx5Kc0BzDpfOQCv8uVZhgs4s BTUnGYZNrDomROVoByXAhjmHr3mafzJyo2TGgjulIu657GMOhK7922eybSoylW3dyHXp Pk7z3Y6UUvGdSxgIivA2S+PsZdZfnuhRj7t4cIdoDDEuccXoIj6USB8HU8lJ60rB5RjC gPI9DumsRAIHmETZwS/5n4TdTq54nslQX6tivHiz99MqoBC2uL92cZGHVxuYO0uPNxtm Yw== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2ncfyps9u7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Oct 2018 02:43:53 +0000 Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w9U2hqDq028642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Oct 2018 02:43:52 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9U2hoSC029597; Tue, 30 Oct 2018 02:43:51 GMT In-Reply-To: <877ei049f6.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4756.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9061 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810300021 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151802 Archived-At: > > OK, I applied the new patch. > > > > Here's my feedback, in case it helps. > > > > For my own code, after the update search seems very slow. > > Just mentioning that - not that it's relevant. >=20 > It is slow when you set lazy-highlight-buffer to t > at the same when isearch-lazy-count is t because > adding overlays to all matches in the full buffer > is very slow and it slows down the counting of matches > that is preformed in the same loop. No, I meant with lazy-highlight-buffer nil. But again, that was only with my own code. I won't worry about that now. > Maybe for optimization we should run the matches-counting loop > first and only after that the full-buffer highlighting loop? Dunno. I'm not worried yet about any interaction between them. But if you want to think about that, good. > > Dunno how much this helps. I again applied the patch > > manually. I've attached the resulting file - perhaps > > you can diff it against what it should be, to see if > > it is faithful or I made a mistake. That might save > > us some time, if I did make a mistake. I don't want > > to provide misleading feedback. >=20 > I see that your version misses an important change in > isearch-lazy-highlight-new-loop. So for your convenience > I attached below a complete patched isearch.el. Ah! Thanks for checking. I'm glad to hear I made a mistake patching. Sorry for taking your time to check it. > > Less relevant - just personal opinion: I prefer the > > numbering in the prefix form CURRENT/TOTAL, rather > > than the suffix, I think. But I could change my mind. > > What are the reasons you prefer it as a suffix - or is > > it just better in terms of implementation/performance? >=20 > I have no preference. For example, Chromium displays the > count as CURRENT/TOTAL whereas Firefox as (CURRENT of TOTAL). > So I changed back to CURRENT/TOTAL in the prefix here: Thanks. I'll take a look and get back to you. - D