From: Paul Eggert <eggert@cs.ucla.edu>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: Matthew Leach <matthew@mattleach.net>, emacs-devel@gnu.org
Subject: Re: Build failure from trunk
Date: Wed, 08 May 2013 07:46:50 -0700 [thread overview]
Message-ID: <518A655A.4080508@cs.ucla.edu> (raw)
In-Reply-To: <E533DAA0-3C19-48B5-ADDF-454AE0B0F89E@swipnet.se>
On 05/07/2013 10:06 PM, Jan Djärv wrote:
> #if !defined USE_GTK || GTK_MAJOR_VERSION < 3 + (GTK_MINOR_VERSION < 4)
>
> This will be true for Gtk 4.0 to 4.3, 5.0 to 5.3, 6.0 to 6.3 and so on, so it is obviously not correct.
Sorry, I don't see the bug. Perhaps you misread the "+" as "|"?
For 4.0, for example, GTK_MAJOR_VERSION is 4 and GTK_MINOR_VERSION is 0,
so the comparison evaluates to 4 < 3 + (0 < 4),
which is false, which is what is wanted here.
next prev parent reply other threads:[~2013-05-08 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 8:43 Build failure from trunk Matthew Leach
2013-05-07 17:48 ` Jan Djärv
2013-05-07 19:29 ` Paul Eggert
2013-05-08 5:06 ` Jan Djärv
2013-05-08 14:46 ` Paul Eggert [this message]
2013-05-08 16:01 ` Jan Djärv
2013-05-08 23:00 ` Paul Eggert
2013-05-09 8:10 ` Jan Djärv
2013-05-09 14:51 ` Paul Eggert
2013-05-09 15:19 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518A655A.4080508@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=matthew@mattleach.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.