From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: bug#9782: 24.0.90; move-to-window-line not taking header line into account Date: Sun, 05 May 2013 06:59:48 +0400 Message-ID: <5185CB24.5060207@yandex.ru> References: <83mxcyuw60.fsf@gnu.org> <87haiiqwiz.fsf@yandex.ru> <83vc6yf8hr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1367722809 9515 80.91.229.3 (5 May 2013 03:00:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 May 2013 03:00:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 05 05:00:06 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UYpBG-0008Um-1g for ged-emacs-devel@m.gmane.org; Sun, 05 May 2013 05:00:06 +0200 Original-Received: from localhost ([::1]:40242 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYpBF-0006VB-JX for ged-emacs-devel@m.gmane.org; Sat, 04 May 2013 23:00:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYpB8-0006Uc-LB for emacs-devel@gnu.org; Sat, 04 May 2013 23:00:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYpB4-0001AD-Ln for emacs-devel@gnu.org; Sat, 04 May 2013 22:59:58 -0400 Original-Received: from mail-lb0-f172.google.com ([209.85.217.172]:58459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYpB0-00019i-4P; Sat, 04 May 2013 22:59:50 -0400 Original-Received: by mail-lb0-f172.google.com with SMTP id y6so2549819lbh.17 for ; Sat, 04 May 2013 19:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding:x-antivirus:x-antivirus-status; bh=DMzIZ2IeBpTuLVNXT1yJivUUT2dptGi75YihC9xywHQ=; b=0KLBWd1iU23bQot27HpLJANSOQYXURcohOVMFc63CghScsjmzGprn6Y8vmjbUFClY3 zdGrTxd57u9OW6ZusJ9uGI27b7LuaejXCSi24DTCMxi8ct2jt1WRVT6dsGtXV1/Nm6pW 6qwt4QxY7e3K39zvrluNv9bEwJ0W0sECNMs/v/7FicFQ/RupChPayV+2XB7uGPtKs44w NnbPVDW20mNAdvwPnakRv3Fou+ckIkNPMB4HnX7jAEOkYHpD4EeTYPeGSTZTyL8pl5te +JFJd62RrSmomvzXsCxPptlUq4V8Io7BO37hr2K0ju1VO+DRfYsVyYksxzILvk2Sj0TL 9ceg== X-Received: by 10.112.151.34 with SMTP id un2mr6139205lbb.14.1367722788709; Sat, 04 May 2013 19:59:48 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id l20sm6411191lbv.9.2013.05.04.19.59.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 04 May 2013 19:59:47 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 In-Reply-To: <83vc6yf8hr.fsf@gnu.org> X-Antivirus: avast! (VPS 130504-1, 04.05.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.217.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159309 Archived-At: On 05.05.2013 6:47, Eli Zaretskii wrote: >> From: Dmitry Gutov >> Cc: eliz@gnu.org >> Date: Sun, 05 May 2013 01:12:52 +0400 >> >> What do you suggest would be a better way to get the window row of a >> buffer position, save that value, and then move to that row later? >> >> Currently, company calls (cdr (posn-actual-col-row posn)) to retrieve >> the row, and `move-to-window-line' to get to it. >> >> Simply adjusting the row number for presence of `header-line-format' >> won't do, because company strives to support Emacs 23 (and maybe even >> 22), and `post-actual-col-row' behavior was different before the >> revision 106022. > > Why is that a problem to have special code for specific Emacs > versions? It's ugly, for one thing. If you don't have any better suggestions, I'll do that, I guess. But it's a seemingly reasonable piece of code, it worked, and your change made it break in some peculiar special case important to some users. That might imply that the code doesn't make sense on some higher level. So I thought you could suggest how that code could be written better/faster/stronger instead.