* bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port
[not found] <87r0azawml.fsf@>
@ 2024-08-16 20:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-16 20:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-07 23:24 ` bug#72526: Needs NEWS item and doc change Tim Ruffing
2 siblings, 0 replies; 4+ messages in thread
From: Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-08-16 20:02 UTC (permalink / raw)
To: 72526
Could someone please review my patch?
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port
[not found] <87r0azawml.fsf@>
2024-08-16 20:02 ` bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-08-16 20:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-07 23:24 ` bug#72526: Needs NEWS item and doc change Tim Ruffing
2 siblings, 0 replies; 4+ messages in thread
From: Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-08-16 20:02 UTC (permalink / raw)
To: 72526
Could someone please review my patch?
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#72526: Needs NEWS item and doc change
[not found] <87r0azawml.fsf@>
2024-08-16 20:02 ` bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-16 20:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2025-01-07 23:24 ` Tim Ruffing
2025-01-08 2:57 ` Stefan Kangas
2 siblings, 1 reply; 4+ messages in thread
From: Tim Ruffing @ 2025-01-07 23:24 UTC (permalink / raw)
To: 72526
I think the first patch (commit a7a22e7) is a good change, but it
should get a NEWS item because it breaks existing configurations.
If you had this in your netrc file:
machine www.example.com:443 port https login foo password bar
Then it needs to be changed to:
machine www.example.com port https login foo password bar
See https://github.com/dengste/org-caldav/issues/320 for reports of
people running into this. This is true not only for netrc files but
also for other authinfo backends. (For example, I've run into this
issue with the GNOME keyring / Secret Service API.)
Moreover, the docs need to be updated. doc/misc/auth.texi has an
example that uses `yourmachine.com:80`. This should be changed to
`yourmachine.com`. (Or better, `example.com` or some domain reserved
for documentation, see https://www.iana.org/help/example-domains ).
Best,
Tim
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#72526: Needs NEWS item and doc change
2025-01-07 23:24 ` bug#72526: Needs NEWS item and doc change Tim Ruffing
@ 2025-01-08 2:57 ` Stefan Kangas
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2025-01-08 2:57 UTC (permalink / raw)
To: Tim Ruffing, 72526; +Cc: Björn Bidar
Tim Ruffing <dev@real-or-random.org> writes:
> I think the first patch (commit a7a22e7) is a good change, but it
> should get a NEWS item because it breaks existing configurations.
>
> If you had this in your netrc file:
> machine www.example.com:443 port https login foo password bar
> Then it needs to be changed to:
> machine www.example.com port https login foo password bar
>
> See https://github.com/dengste/org-caldav/issues/320 for reports of
> people running into this. This is true not only for netrc files but
> also for other authinfo backends. (For example, I've run into this
> issue with the GNOME keyring / Secret Service API.)
>
> Moreover, the docs need to be updated. doc/misc/auth.texi has an
> example that uses `yourmachine.com:80`. This should be changed to
> `yourmachine.com`. (Or better, `example.com` or some domain reserved
> for documentation, see https://www.iana.org/help/example-domains ).
Björn, could you please take a look at this?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-08 2:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87r0azawml.fsf@>
2024-08-16 20:02 ` bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-16 20:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-07 23:24 ` bug#72526: Needs NEWS item and doc change Tim Ruffing
2025-01-08 2:57 ` Stefan Kangas
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.