From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Ben North" Newsgroups: gmane.emacs.devel Subject: Doc suggestion for `cursor-type' in buffer.c Date: Fri, 7 Nov 2008 09:42:19 +0000 Message-ID: <5169ff10811070142v7961bc3la1bc0e3aef9173b0@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1226055528 6830 80.91.229.12 (7 Nov 2008 10:58:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Nov 2008 10:58:48 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 07 11:59:51 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KyP49-0002TB-Dz for ged-emacs-devel@m.gmane.org; Fri, 07 Nov 2008 11:59:49 +0100 Original-Received: from localhost ([127.0.0.1]:37930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KyP32-0005qK-7H for ged-emacs-devel@m.gmane.org; Fri, 07 Nov 2008 05:58:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KyNrE-0002r3-FA for emacs-devel@gnu.org; Fri, 07 Nov 2008 04:42:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KyNrD-0002q5-9Y for emacs-devel@gnu.org; Fri, 07 Nov 2008 04:42:23 -0500 Original-Received: from [199.232.76.173] (port=36694 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KyNrC-0002pm-Og for emacs-devel@gnu.org; Fri, 07 Nov 2008 04:42:22 -0500 Original-Received: from ey-out-1920.google.com ([74.125.78.149]:44412) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KyNrC-00046I-SF for emacs-devel@gnu.org; Fri, 07 Nov 2008 04:42:23 -0500 Original-Received: by ey-out-1920.google.com with SMTP id 4so471562eyg.24 for ; Fri, 07 Nov 2008 01:42:20 -0800 (PST) Original-Received: by 10.103.244.19 with SMTP id w19mr1634747mur.134.1226050939741; Fri, 07 Nov 2008 01:42:19 -0800 (PST) Original-Received: by 10.103.5.8 with HTTP; Fri, 7 Nov 2008 01:42:19 -0800 (PST) Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-Mailman-Approved-At: Fri, 07 Nov 2008 05:49:30 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105434 Archived-At: The docstring for the variable `cursor-type' ends with the text When the buffer is displayed in a nonselected window, this variable has no effect; the cursor appears as a hollow box. which suggests the user has no control over the cursor when in a non-selected window. In fact the user can control this, by means of the variable `cursor-in-non-selected-windows'. Would a patch like the below (made against CVS 1.571) clarify the docstring? Ben. diff -Nur ORIG/buffer.c NEW/buffer.c --- ORIG/buffer.c 2008-11-07 09:28:13.621444300 +0000 +++ NEW/buffer.c 2008-11-07 09:32:17.647201000 +0000 @@ -6213,8 +6213,9 @@ (hbar . HEIGHT) display a horizontal bar cursor with height HEIGHT ANYTHING ELSE display a hollow box cursor -When the buffer is displayed in a nonselected window, -this variable has no effect; the cursor appears as a hollow box. */); +When the buffer is displayed in a nonselected window, the cursor's +appearance is instead controlled by the variable +`cursor-in-non-selected-windows'. */); DEFVAR_PER_BUFFER ("line-spacing", ¤t_buffer->extra_line_spacing, Qnil,