all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Николай Сущенко" <sckol@yandex.ru>
To: 7781@debbugs.gnu.org
Subject: bug#7781: [PATCH] Fix ispell problem with hunspell and UTF-8 file
Date: Sat, 13 Apr 2013 23:12:38 +0400	[thread overview]
Message-ID: <5169AE26.1000403@yandex.ru> (raw)
In-Reply-To: <87sjx9fula.fsf@sc3d.org>

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

As soon as I can see, the hunspell team haven't fixed the bug in more 
then 2 years. Maybe for them it is not a bug but a feature.

The problem is that hunspell reports byte-position instead of 
char-position with multi-byte character input, while Emacs waits for 
char-position. With the patch attached I propose to make conversation in 
the ispell-parse-output function.

Thanks,
Nikolay Suschenko

[-- Attachment #2: ispell.el.patch --]
[-- Type: text/plain, Size: 794 bytes --]

--- a/lisp/textmodes/ispell.el	2013-02-22 13:09:26.000000000 +0400
+++ b/lisp/textmodes/ispell.el	2013-04-13 22:46:35.209323584 +0400
@@ -2597,7 +2597,11 @@
 	  (setq count 0)		; no misses for type #
 	(setq count (string-to-number output) ; get number of misses.
 	      output (substring output (1+ (string-match " " output 1)))))
-      (setq offset (string-to-number output))
+      ; hunspell reports byte-position instead of char-position
+      ; with multi-byte character input
+      (setq offset (if ispell-really-hunspell
+		       (byte-to-position (string-to-number output))
+		     (string-to-number output)))
       (setq output (if (eq type ?#)     ; No miss or guess list.
                        nil
                      (substring output (1+ (string-match " " output 1)))))

  parent reply	other threads:[~2013-04-13 19:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-03 23:14 bug#7781: 23.2.91; ispell problem with hunspell and UTF-8 file Reuben Thomas
2011-01-07 13:14 ` Agustin Martin
2011-01-07 14:30   ` Reuben Thomas
2011-02-11 17:00   ` Agustin Martin
2014-10-16 13:37     ` Agustin Martin
2014-10-16 13:54       ` Eli Zaretskii
2014-10-16 14:08         ` Agustin Martin
2012-01-01 21:42 ` bug#7781: ispell problem with hunspell and UTF-8 file (and other, related hunspell problems) Richard Wordingham
2013-04-13 19:12 ` Николай Сущенко [this message]
2013-04-14  5:42   ` bug#7781: [PATCH] Fix ispell problem with hunspell and UTF-8 file Eli Zaretskii
2013-04-14  6:33     ` Николай Сущенко
2013-04-14  7:08       ` Eli Zaretskii
2013-04-20 18:43         ` Николай Сущенко
2014-04-27 21:30 ` bug#7781: hunspell and latex-mode Peter Münster
2014-04-28 15:37   ` Eli Zaretskii
2014-04-28 16:18     ` Peter Münster
2014-04-28 16:48       ` Eli Zaretskii
2014-04-28 17:17         ` Peter Münster
2014-04-28 17:32           ` Eli Zaretskii
2014-04-28 18:27             ` Peter Münster
2014-04-29 10:03       ` Agustin Martin
2014-04-29 10:13         ` Peter Münster
2014-04-29 10:21           ` Agustin Martin
2014-04-29 10:20         ` Peter Münster
2014-04-29 10:39           ` Agustin Martin
2014-04-29 11:54             ` Peter Münster
2014-04-29 12:48               ` Peter Münster
2014-04-29 13:57                 ` Eli Zaretskii
2014-04-29 14:30                   ` Peter Münster
2014-04-29 15:25                     ` Eli Zaretskii
2014-04-29 16:34                       ` Peter Münster
2014-09-25  9:54 ` bug#7781: Bug still present in hunspell 1.3.3; Eli's patch still works Reuben Thomas
2020-08-28 12:00 ` bug#7781: 23.2.91; ispell problem with hunspell and UTF-8 file Stefan Kangas
2020-08-28 12:36   ` Eli Zaretskii
2020-08-28 12:56     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5169AE26.1000403@yandex.ru \
    --to=sckol@yandex.ru \
    --cc=7781@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.