all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* python.el doesn't define `comment-start-skip'
@ 2009-01-13 21:43 Davis Herring
  2010-11-15 15:38 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Davis Herring @ 2009-01-13 21:43 UTC (permalink / raw
  To: emacs-devel

It's implied in newcomment.el that `comment-normalize-vars' should be
called before using the library, which creates `comment-start-skip' if
necessary.  However, many programming modes seem to define it themselves;
cperl-mode uses "#+ *", and the old python-mode.el uses just "# *". 
Should this be added?

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: python.el doesn't define `comment-start-skip'
  2009-01-13 21:43 python.el doesn't define `comment-start-skip' Davis Herring
@ 2010-11-15 15:38 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2010-11-15 15:38 UTC (permalink / raw
  To: herring; +Cc: emacs-devel

> It's implied in newcomment.el that `comment-normalize-vars' should be
> called before using the library, which creates `comment-start-skip' if
> necessary.  However, many programming modes seem to define it themselves;
> cperl-mode uses "#+ *", and the old python-mode.el uses just "# *". 
> Should this be added?

The old commenting code (i.e. before newcomment.el) did not know how to
build comment-start-skip from comment-start, so many major modes set
it manually.  Other major modes set it manually because newcomment.el
doesn't do a good enough job of guessing the value of
comment-start-skip.
In the case of python.el I don't think it's necessary.


        Stefan "going through some of his voluminous backlog"



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-11-15 15:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-13 21:43 python.el doesn't define `comment-start-skip' Davis Herring
2010-11-15 15:38 ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.